[Bug 12119] iscsi repeatedly times out

[Bug 12119] iscsi repeatedly times out

[bugme-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=12119


akpm@osdl.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Regression|0                           |1




-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 12119] iscsi repeatedly times out

[bugme-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=12119





------- Comment #1 from anonymous@kernel-bugs.osdl.org  2008-11-30 17:39 -------
Reply-To: michaelc@cs.wisc.edu

bugme-daemon@bugzilla.kernel.org wrote:
> Hardware Environment:diskless i386, swap on iscsi device
> Software Environment:open-iscsi v 6.2

What is the rest of this version string? With fedora run

rpm -q iscsi-initiator-utils


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 12119] iscsi repeatedly times out

[bugme-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=12119





------- Comment #2 from anonymous@kernel-bugs.osdl.org  2008-11-30 20:11 -------
Reply-To: michaelc@cs.wisc.edu

Mike Christie wrote:
> bugme-daemon@bugzilla.kernel.org wrote:
>> Hardware Environment:diskless i386, swap on iscsi device
>> Software Environment:open-iscsi v 6.2
> 
> What is the rest of this version string? With fedora run
> 
> rpm -q iscsi-initiator-utils

Ignore that request.

Try the attached patch made over 2.6.27 which was the base for the 
kernel I thought you were using. This should also work with 2.6.28-rc*.

Oh yeah for 2.6.27 are you using a fedora kernel? If you are building 
your own kernel and you are using F8 then make sure you compile the 
kernel with

CONFIG_SYSFS_DEPRECATED=y
CONFIG_SYSFS_DEPRECATED_V2=y

because a lot of tools in F8 may not work right without it.  The older 
iscsi tools in there will not and you will run into lots of other 
problems, because there were some sysfs changes which affected iscsi and 
we were not ready for them back then. Newer tools in F9 and F10  and 
open-iscsi.org will handle any sysfs layout so if you can you might want 
to grab the iscsi-initiator-utils rpm from the F9 repository.
--- linux-2.6.27-rc5.work/drivers/scsi/libiscsi.c       2008-08-28
17:52:02.000000000 -0500
+++ linux-2.6.27-rc5/drivers/scsi/libiscsi.c    2008-11-30 21:46:55.000000000
-0600
@@ -494,12 +494,6 @@ __iscsi_conn_send_pdu(struct iscsi_conn 
                if (!__kfifo_get(session->cmdpool.queue,
                                 (void*)&task, sizeof(void*)))
                        return NULL;
-
-               if ((hdr->opcode == (ISCSI_OP_NOOP_OUT | ISCSI_OP_IMMEDIATE))
&&
-                    hdr->ttt == RESERVED_ITT) {
-                       conn->ping_task = task;
-                       conn->last_ping = jiffies;
-               }
        }
        /*
         * released in complete pdu for task we expect a response for, and
@@ -674,6 +668,11 @@ static void iscsi_send_nopout(struct isc
        task = __iscsi_conn_send_pdu(conn, (struct iscsi_hdr *)&hdr, NULL, 0);
        if (!task)
                iscsi_conn_printk(KERN_ERR, conn, "Could not send nopout\n");
+       else if (!rhdr) {
+               /* only track our nops */
+               conn->ping_task = task;
+               conn->last_ping = jiffies;
+       }
 }

 static int iscsi_handle_reject(struct iscsi_conn *conn, struct iscsi_hdr *hdr,


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 12119] iscsi repeatedly times out

[bugme-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=12119





------- Comment #3 from ian@beware.dropbear.id.au  2008-12-01 05:39 -------
Thanks. The patch wouldn't apply but I applied it by hand. It works fine.

I didn't know about the CONFIG_SYSFS_DEPRECIATED options. Unfortunately I can't
upgrade to FC9 or FC10 because of a kernel nfs bug(s) [11061,11154]. I'm not
sure if I could run FC10 with an older kernel, but things like the changes to
sysfs shows it is best not to assume so!


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Re: [Bug 12119] iscsi repeatedly times out

[Mike Christie]

bugme-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=12119
> 
> 
> 
> 
> 
> ------- Comment #3 from ian@beware.dropbear.id.au  2008-12-01 05:39 -------
> Thanks. The patch wouldn't apply but I applied it by hand. It works fine.

Ok. I will submit a patch. Thanks for the report and testing.


> 
> I didn't know about the CONFIG_SYSFS_DEPRECIATED options. Unfortunately I can't
> upgrade to FC9 or FC10 because of a kernel nfs bug(s) [11061,11154]. I'm not
> sure if I could run FC10 with an older kernel, but things like the changes to
> sysfs shows it is best not to assume so!
> 

I did not mean to upgrade to all F10 or F9 - just the iscsi package in 
there. The code across them is the same more or less. F9 and F8 were the 
same for iscsi, so if you use:

http://mirrors.kernel.org/fedora/updates/9/x86_64.newkey/iscsi-initiator-utils-6.2.0.870-1.0.fc9.x86_64.rpm

(for i386 or ppc then swap the x86_64 refs for your arch) on F8 then you 
should be ok.

[Bug 12119] iscsi repeatedly times out

[bugme-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=12119





------- Comment #4 from anonymous@kernel-bugs.osdl.org  2008-12-01 08:20 -------
Reply-To: michaelc@cs.wisc.edu

bugme-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=12119
> 
> 
> 
> 
> 
> ------- Comment #3 from ian@beware.dropbear.id.au  2008-12-01 05:39 -------
> Thanks. The patch wouldn't apply but I applied it by hand. It works fine.

Ok. I will submit a patch. Thanks for the report and testing.


> 
> I didn't know about the CONFIG_SYSFS_DEPRECIATED options. Unfortunately I can't
> upgrade to FC9 or FC10 because of a kernel nfs bug(s) [11061,11154]. I'm not
> sure if I could run FC10 with an older kernel, but things like the changes to
> sysfs shows it is best not to assume so!
> 

I did not mean to upgrade to all F10 or F9 - just the iscsi package in 
there. The code across them is the same more or less. F9 and F8 were the 
same for iscsi, so if you use:

http://mirrors.kernel.org/fedora/updates/9/x86_64.newkey/iscsi-initiator-utils-6.2.0.870-1.0.fc9.x86_64.rpm

(for i386 or ppc then swap the x86_64 refs for your arch) on F8 then you 
should be ok.


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 12119] iscsi repeatedly times out

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=12119


Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |alan@lxorguk.ukuu.org.uk
         Resolution|                            |OBSOLETE




-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 12119] iscsi repeatedly times out

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=12119


Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.