Re: [patch] iscsi-target: remove some dead code

[Dan Carpenter <dan.carpenter@oracle.com>]

On Thu, May 17, 2012 at 11:58:40AM +0200, walter harms wrote:
> 
> 
> Am 17.05.2012 09:08, schrieb Dan Carpenter:
> > Neither "acceptor_values" nor "proposer_values" can be NULL here.
> > Smatch complains because we are not allowed to pass NULL pointers to
> > strchr().
> > 
> > Also I removed a second later check for "!acceptor_values" because it
> > gets checked on the next line in the do while condition.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > Compile tested only.  Please review carefully.
> > 
> > diff --git a/drivers/target/iscsi/iscsi_target_parameters.c b/drivers/target/iscsi/iscsi_target_parameters.c
> > index ad3b3c1..ed5241e 100644
> > --- a/drivers/target/iscsi/iscsi_target_parameters.c
> > +++ b/drivers/target/iscsi/iscsi_target_parameters.c
> > @@ -1037,13 +1037,6 @@ static char *iscsi_check_valuelist_for_support(
> >  			tmp2 = strchr(acceptor_values, ',');
> >  			if (tmp2)
> >  				*tmp2 = '\0';
> this looks like strchrnul(). I realy do not know is this supported inside the kernel ?
> 

It can't be NULL here.  Adding bogus checks is the wrong idea and
static checkers are right to ask about needless checks.

regards,
dan carpenter