From: "Jörn Engel" <joern@logfs.org>
To: walter harms <wharms@bfs.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Andy Grover <agrover@redhat.com>, Jesper Juhl <jj@chaosbits.net>,
Roland Dreier <roland@kernel.org>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] iscsi-target: remove some dead code
Date: Thu, 17 May 2012 11:15:13 -0400 [thread overview]
Message-ID: <20120517151513.GD17575@logfs.org> (raw)
In-Reply-To: <4FB4CBD0.8000503@bfs.de>
On Thu, 17 May 2012 11:58:40 +0200, walter harms wrote:
>
> the changes look reasonable but to be fair the code should have an explanation
> what it is supposed to do. I do not have the feeling that i did understand the
> purpose completely.
I suppose that is a decent summary for much of the target code.
Patches are clearly welcome.
Jörn
--
Fancy algorithms are buggier than simple ones, and they're much harder
to implement. Use simple algorithms as well as simple data structures.
-- Rob Pike
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-05-17 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 7:08 [patch] iscsi-target: remove some dead code Dan Carpenter
2012-05-17 7:39 ` Nicholas A. Bellinger
2012-05-17 9:58 ` walter harms
2012-05-17 10:26 ` Dan Carpenter
2012-05-17 15:15 ` Jörn Engel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120517151513.GD17575@logfs.org \
--to=joern@logfs.org \
--cc=agrover@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=jj@chaosbits.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=roland@kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox