[Bug 9872] Driver 'sd' needs updating - please use bus_type methods

[Bug 9872] Driver 'sd' needs updating - please use bus_type methods

[bugme-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=9872


randy.dunlap@oracle.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|dwmw2@infradead.org         |scsi_drivers-other@kernel-
                   |                            |bugs.osdl.org




-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 9872] Driver 'sd' needs updating - please use bus_type methods

[bugme-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=9872


protasnb@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|scsi_drivers-other@kernel-  |linux-scsi@vger.kernel.org
                   |bugs.osdl.org               |




-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Re: [Bug 9872] Driver 'sd' needs updating - please use bus_type methods

[James Bottomley]

On Sat, 2008-05-03 at 17:22 -0700, bugme-daemon@bugzilla.kernel.org
wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=9872

This isn't a bug.  There have been numerous discussions about fixing it.

The warning comes out of here in drivers/base/driver.c:

	if ((drv->bus->probe && drv->probe) ||
	    (drv->bus->remove && drv->remove) ||
	    (drv->bus->shutdown && drv->shutdown))
		printk(KERN_WARNING "Driver '%s' needs updating - please use "
			"bus_type methods\n", drv->name);

The problem is that SCSI drivers have both: SCSI uses the bus methods to
trigger the probe and remove (as it must having a bus method) but it
also uses the individual struct driver probe and remove methods to
rethrow the events to the ULDs.

According to Kay and Greg, this is a legitimate way of operating, and
they're not going to remove the driver methods (otherwise we'd just take
them into struct scsi_driver), so we're stuck trying to find a way to
prevent the base warning about this.

James

[Bug 9872] Driver 'sd' needs updating - please use bus_type methods

[bugme-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=9872





------- Comment #1 from anonymous@kernel-bugs.osdl.org  2008-05-04 07:34 -------
Reply-To: James.Bottomley@HansenPartnership.com

On Sat, 2008-05-03 at 17:22 -0700, bugme-daemon@bugzilla.kernel.org
wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=9872

This isn't a bug.  There have been numerous discussions about fixing it.

The warning comes out of here in drivers/base/driver.c:

        if ((drv->bus->probe && drv->probe) ||
            (drv->bus->remove && drv->remove) ||
            (drv->bus->shutdown && drv->shutdown))
                printk(KERN_WARNING "Driver '%s' needs updating - please use "
                        "bus_type methods\n", drv->name);

The problem is that SCSI drivers have both: SCSI uses the bus methods to
trigger the probe and remove (as it must having a bus method) but it
also uses the individual struct driver probe and remove methods to
rethrow the events to the ULDs.

According to Kay and Greg, this is a legitimate way of operating, and
they're not going to remove the driver methods (otherwise we'd just take
them into struct scsi_driver), so we're stuck trying to find a way to
prevent the base warning about this.

James


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Re: [Bug 9872] Driver 'sd' needs updating - please use bus_type methods

[Kay Sievers]

On Sun, 2008-05-04 at 09:34 -0500, James Bottomley wrote:
> On Sat, 2008-05-03 at 17:22 -0700, bugme-daemon@bugzilla.kernel.org
> wrote:
> > http://bugzilla.kernel.org/show_bug.cgi?id=9872
> 
> This isn't a bug.  There have been numerous discussions about fixing it.

It is a kind of a "bug". The core does not call driver functions, if
bus_type is provided. So the warning is fine according to the current
logic of the core, telling you it will ignore things a driver asked for.

> The warning comes out of here in drivers/base/driver.c:
> 
> 	if ((drv->bus->probe && drv->probe) ||
> 	    (drv->bus->remove && drv->remove) ||
> 	    (drv->bus->shutdown && drv->shutdown))
> 		printk(KERN_WARNING "Driver '%s' needs updating - please use "
> 			"bus_type methods\n", drv->name);
> 
> The problem is that SCSI drivers have both: SCSI uses the bus methods to
> trigger the probe and remove (as it must having a bus method) but it
> also uses the individual struct driver probe and remove methods to
> rethrow the events to the ULDs.

Looks like it does not use probe() on the bus. Now lets get rid of
remove(). :)

> According to Kay and Greg, this is a legitimate way of operating, and
> they're not going to remove the driver methods (otherwise we'd just take
> them into struct scsi_driver), so we're stuck trying to find a way to
> prevent the base warning about this.

Right, I guess, they are not going away, but you still should only use
one of them, and not both at the same time.

How about the following patch? Which does not use driver core pointers,
which are ignored by the core, to do private SCSI stuff.

Thanks,
Kay 



From: Hannes Reinecke <hare@suse.de>
Subject: SCSI: do not use bus_type->remove() and driver->remove() at the same time

If a driver sets blk_queue_prep_rq(), it should clean it up itself, and
not from the bus callbacks. This removes the need to hook into bus->remove(),
which should not be used at the same time as driver->remove().

Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
---

 drivers/scsi/scsi_lib.c    |    1 +
 drivers/scsi/scsi_priv.h   |    1 -
 drivers/scsi/scsi_sysfs.c  |   17 -----------------
 drivers/scsi/sd.c          |    2 ++
 drivers/scsi/sr.c          |    1 +
 include/scsi/scsi_driver.h |    1 +
 6 files changed, 5 insertions(+), 18 deletions(-)

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index a82d2fe..16d21d2 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -1267,6 +1267,7 @@ int scsi_prep_fn(struct request_queue *q, struct request *req)
 		ret = scsi_setup_blk_pc_cmnd(sdev, req);
 	return scsi_prep_return(q, req, ret);
 }
+EXPORT_SYMBOL(scsi_prep_fn);
 
 /*
  * scsi_dev_queue_ready: if we can send requests to sdev, return 1 else
diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h
index b33e725..8dd1e3b 100644
--- a/drivers/scsi/scsi_priv.h
+++ b/drivers/scsi/scsi_priv.h
@@ -76,7 +76,6 @@ extern int scsi_init_queue(void);
 extern void scsi_exit_queue(void);
 struct request_queue;
 struct request;
-extern int scsi_prep_fn(struct request_queue *, struct request *);
 
 /* scsi_proc.c */
 #ifdef CONFIG_SCSI_PROC_FS
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 049103f..ad0b88b 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -410,29 +410,12 @@ static int scsi_bus_resume(struct device * dev)
 	return err;
 }
 
-static int scsi_bus_remove(struct device *dev)
-{
-	struct device_driver *drv = dev->driver;
-	struct scsi_device *sdev = to_scsi_device(dev);
-	int err = 0;
-
-	/* reset the prep_fn back to the default since the
-	 * driver may have altered it and it's being removed */
-	blk_queue_prep_rq(sdev->request_queue, scsi_prep_fn);
-
-	if (drv && drv->remove)
-		err = drv->remove(dev);
-
-	return 0;
-}
-
 struct bus_type scsi_bus_type = {
         .name		= "scsi",
         .match		= scsi_bus_match,
 	.uevent		= scsi_bus_uevent,
 	.suspend	= scsi_bus_suspend,
 	.resume		= scsi_bus_resume,
-	.remove		= scsi_bus_remove,
 };
 
 int scsi_sysfs_register(void)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 01cefbb..672a17a 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1743,6 +1743,8 @@ static int sd_remove(struct device *dev)
 {
 	struct scsi_disk *sdkp = dev_get_drvdata(dev);
 
+	blk_queue_prep_rq(sdkp->device->request_queue, scsi_prep_fn);
+
 	device_del(&sdkp->dev);
 	del_gendisk(sdkp->disk);
 	sd_shutdown(dev);
diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
index 7ee86d4..5860dc7 100644
--- a/drivers/scsi/sr.c
+++ b/drivers/scsi/sr.c
@@ -901,6 +901,7 @@ static int sr_remove(struct device *dev)
 {
 	struct scsi_cd *cd = dev_get_drvdata(dev);
 
+	blk_queue_prep_rq(cd->device->request_queue, scsi_prep_fn);
 	del_gendisk(cd->disk);
 
 	mutex_lock(&sr_ref_mutex);
diff --git a/include/scsi/scsi_driver.h b/include/scsi/scsi_driver.h
index 1f5ca7f..9fd6702 100644
--- a/include/scsi/scsi_driver.h
+++ b/include/scsi/scsi_driver.h
@@ -32,5 +32,6 @@ int scsi_setup_blk_pc_cmnd(struct scsi_device *sdev, struct request *req);
 int scsi_setup_fs_cmnd(struct scsi_device *sdev, struct request *req);
 int scsi_prep_state_check(struct scsi_device *sdev, struct request *req);
 int scsi_prep_return(struct request_queue *q, struct request *req, int ret);
+int scsi_prep_fn(struct request_queue *, struct request *);
 
 #endif /* _SCSI_SCSI_DRIVER_H */

[Bug 9872] Driver 'sd' needs updating - please use bus_type methods

[bugme-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=9872





------- Comment #2 from kay.sievers@vrfy.org  2008-05-05 09:24 -------
On Sun, 2008-05-04 at 09:34 -0500, James Bottomley wrote:
> On Sat, 2008-05-03 at 17:22 -0700, bugme-daemon@bugzilla.kernel.org
> wrote:
> > http://bugzilla.kernel.org/show_bug.cgi?id=9872
> 
> This isn't a bug.  There have been numerous discussions about fixing it.

It is a kind of a "bug". The core does not call driver functions, if
bus_type is provided. So the warning is fine according to the current
logic of the core, telling you it will ignore things a driver asked for.

> The warning comes out of here in drivers/base/driver.c:
> 
> 	if ((drv->bus->probe && drv->probe) ||
> 	    (drv->bus->remove && drv->remove) ||
> 	    (drv->bus->shutdown && drv->shutdown))
> 		printk(KERN_WARNING "Driver '%s' needs updating - please use "
> 			"bus_type methods\n", drv->name);
> 
> The problem is that SCSI drivers have both: SCSI uses the bus methods to
> trigger the probe and remove (as it must having a bus method) but it
> also uses the individual struct driver probe and remove methods to
> rethrow the events to the ULDs.

Looks like it does not use probe() on the bus. Now lets get rid of
remove(). :)

> According to Kay and Greg, this is a legitimate way of operating, and
> they're not going to remove the driver methods (otherwise we'd just take
> them into struct scsi_driver), so we're stuck trying to find a way to
> prevent the base warning about this.

Right, I guess, they are not going away, but you still should only use
one of them, and not both at the same time.

How about the following patch? Which does not use driver core pointers,
which are ignored by the core, to do private SCSI stuff.

Thanks,
Kay 



From: Hannes Reinecke <hare@suse.de>
Subject: SCSI: do not use bus_type->remove() and driver->remove() at the same
time

If a driver sets blk_queue_prep_rq(), it should clean it up itself, and
not from the bus callbacks. This removes the need to hook into bus->remove(),
which should not be used at the same time as driver->remove().

Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
---

 drivers/scsi/scsi_lib.c    |    1 +
 drivers/scsi/scsi_priv.h   |    1 -
 drivers/scsi/scsi_sysfs.c  |   17 -----------------
 drivers/scsi/sd.c          |    2 ++
 drivers/scsi/sr.c          |    1 +
 include/scsi/scsi_driver.h |    1 +
 6 files changed, 5 insertions(+), 18 deletions(-)

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index a82d2fe..16d21d2 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -1267,6 +1267,7 @@ int scsi_prep_fn(struct request_queue *q, struct request
*req)
                ret = scsi_setup_blk_pc_cmnd(sdev, req);
        return scsi_prep_return(q, req, ret);
 }
+EXPORT_SYMBOL(scsi_prep_fn);

 /*
  * scsi_dev_queue_ready: if we can send requests to sdev, return 1 else
diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h
index b33e725..8dd1e3b 100644
--- a/drivers/scsi/scsi_priv.h
+++ b/drivers/scsi/scsi_priv.h
@@ -76,7 +76,6 @@ extern int scsi_init_queue(void);
 extern void scsi_exit_queue(void);
 struct request_queue;
 struct request;
-extern int scsi_prep_fn(struct request_queue *, struct request *);

 /* scsi_proc.c */
 #ifdef CONFIG_SCSI_PROC_FS
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 049103f..ad0b88b 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -410,29 +410,12 @@ static int scsi_bus_resume(struct device * dev)
        return err;
 }

-static int scsi_bus_remove(struct device *dev)
-{
-       struct device_driver *drv = dev->driver;
-       struct scsi_device *sdev = to_scsi_device(dev);
-       int err = 0;
-
-       /* reset the prep_fn back to the default since the
-        * driver may have altered it and it's being removed */
-       blk_queue_prep_rq(sdev->request_queue, scsi_prep_fn);
-
-       if (drv && drv->remove)
-               err = drv->remove(dev);
-
-       return 0;
-}
-
 struct bus_type scsi_bus_type = {
         .name          = "scsi",
         .match         = scsi_bus_match,
        .uevent         = scsi_bus_uevent,
        .suspend        = scsi_bus_suspend,
        .resume         = scsi_bus_resume,
-       .remove         = scsi_bus_remove,
 };

 int scsi_sysfs_register(void)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 01cefbb..672a17a 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1743,6 +1743,8 @@ static int sd_remove(struct device *dev)
 {
        struct scsi_disk *sdkp = dev_get_drvdata(dev);

+       blk_queue_prep_rq(sdkp->device->request_queue, scsi_prep_fn);
+
        device_del(&sdkp->dev);
        del_gendisk(sdkp->disk);
        sd_shutdown(dev);
diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
index 7ee86d4..5860dc7 100644
--- a/drivers/scsi/sr.c
+++ b/drivers/scsi/sr.c
@@ -901,6 +901,7 @@ static int sr_remove(struct device *dev)
 {
        struct scsi_cd *cd = dev_get_drvdata(dev);

+       blk_queue_prep_rq(cd->device->request_queue, scsi_prep_fn);
        del_gendisk(cd->disk);

        mutex_lock(&sr_ref_mutex);
diff --git a/include/scsi/scsi_driver.h b/include/scsi/scsi_driver.h
index 1f5ca7f..9fd6702 100644
--- a/include/scsi/scsi_driver.h
+++ b/include/scsi/scsi_driver.h
@@ -32,5 +32,6 @@ int scsi_setup_blk_pc_cmnd(struct scsi_device *sdev, struct
request *req);
 int scsi_setup_fs_cmnd(struct scsi_device *sdev, struct request *req);
 int scsi_prep_state_check(struct scsi_device *sdev, struct request *req);
 int scsi_prep_return(struct request_queue *q, struct request *req, int ret);
+int scsi_prep_fn(struct request_queue *, struct request *);

 #endif /* _SCSI_SCSI_DRIVER_H */


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 9872] Driver 'sd' needs updating - please use bus_type methods

[bugme-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=9872


protasnb@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |protasnb@gmail.com




------- Comment #3 from protasnb@gmail.com  2008-06-01 23:46 -------
Russel, did you get chance to test Kay's patch in #2?

Are there plans to submit the patch?
Thanks.


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 9872] Driver 'sd' needs updating - please use bus_type methods

[bugme-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=9872





------- Comment #4 from russell@rickstewart.com  2008-06-05 16:52 -------
(In reply to comment #3)
> Russel, did you get chance to test Kay's patch in #2?

    I did.  It worked.  I had to patch the files by hand because 
of some difference in version, I guess.


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 9872] Driver 'sd' needs updating - please use bus_type methods

[bugme-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=9872


alan@lxorguk.ukuu.org.uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
      KernelVersion|2.6.24                      |2.6.27
         Resolution|                            |CODE_FIX




-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 9872] Driver 'sd' needs updating - please use bus_type methods

[bugme-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=9872


alan@lxorguk.ukuu.org.uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |REOPENED
         Resolution|CODE_FIX                    |




------- Comment #5 from alan@lxorguk.ukuu.org.uk  2009-03-24 04:24 -------
Oops didn't mean to close this


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 9872] Driver 'sd' needs updating - please use bus_type methods

[bugme-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=9872


alan@lxorguk.ukuu.org.uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      KernelVersion|2.6.27                      |2.6.29




-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 9872] Driver 'sd' needs updating - please use bus_type methods

[bugzilla-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=9872


Pacho Ramos <pacho@condmat1.ciencias.uniovi.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pacho@condmat1.ciencias.uni
                   |                            |ovi.es




--- Comment #6 from Pacho Ramos <pacho@condmat1.ciencias.uniovi.es>  2009-07-18 12:34:56 ---
I still get this with kernel-2.6.30 :-/

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 9872] Driver 'sd' needs updating - please use bus_type methods

[bugzilla-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=9872


Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alan@lxorguk.ukuu.org.uk
     Kernel Version|2.6.29                      |2.6.30
         Regression|---                         |No




-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 9872] Driver 'sd' needs updating - please use bus_type methods

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=9872


Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |CODE_FIX




-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 9872] Driver 'sd' needs updating - please use bus_type methods

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=9872


Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.