From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] [SCSI] scsi_pm: passing wrong pointer to resume() Date: Fri, 18 May 2012 17:08:27 +0300 Message-ID: <20120518140827.GA1584@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: "James E.J. Bottomley" , Aaron Lu Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Alan Stern List-Id: linux-scsi@vger.kernel.org This gets caught by GCC: drivers/scsi/scsi_pm.c:30:5: warning: passing argument 1 of =E2=80=98scsi_device_resume=E2=80=99 from incompatible pointer type [enabled by default] It probably would have been caught in testing as well, but it's on an error path. Signed-off-by: Dan Carpenter --- I haven't tested this. :/ Sorry for that. diff --git a/drivers/scsi/scsi_pm.c b/drivers/scsi/scsi_pm.c index 9bd2c41..d4201de 100644 --- a/drivers/scsi/scsi_pm.c +++ b/drivers/scsi/scsi_pm.c @@ -27,7 +27,7 @@ static int scsi_dev_type_suspend(struct device *dev, = pm_message_t msg) if (drv && drv->suspend) { err =3D drv->suspend(dev, msg); if (err) - scsi_device_resume(dev); + scsi_device_resume(to_scsi_device(dev)); } } dev_dbg(dev, "scsi suspend: %d\n", err);