* Re: [Bug 10890] Heavy iSCSI traffic triggers memory allocation complaints and system lockup
2012-05-21 15:48 ` [Bug 10890] Heavy iSCSI traffic triggers memory allocation complaints and system lockup bugzilla-daemon
@ 2012-05-21 15:59 ` Mike Christie
0 siblings, 0 replies; 3+ messages in thread
From: Mike Christie @ 2012-05-21 15:59 UTC (permalink / raw)
To: bugzilla-daemon; +Cc: linux-scsi
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
On 05/21/2012 10:48 AM, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=10890
>
Weird. I am just seeing this bz now. Could you try the patches in this
thread
https://lkml.org/lkml/2012/5/17/215
a long with the attached patch for iscsi? The patchset is for swap over
storage, but because we do not check for that case specifially I think
they will allow you to dip into the reserves in your setup.
[-- Attachment #2: 0001-iscsi-Set-SOCK_MEMALLOC-for-access-to-PFMEMALLOC-res.patch --]
[-- Type: text/plain, Size: 1584 bytes --]
From 917d53f16d1e26b12e90e5e15df76a7a8bee35e8 Mon Sep 17 00:00:00 2001
From: Mike Christie <michaelc@cs.wisc.edu>
Date: Thu, 3 May 2012 12:36:18 -0500
Subject: [PATCH 1/1] iscsi: Set SOCK_MEMALLOC for access to PFMEMALLOC
reserves
Set SOCK_MEMALLOC on the iscsi socket to allow access to PFMEMALLOC
reserves to prevent deadlock.
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
---
drivers/scsi/iscsi_tcp.c | 18 +++++++++++++-----
1 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index 453a740..7360f4c 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -370,17 +370,24 @@ static inline int iscsi_sw_tcp_xmit_qlen(struct iscsi_conn *conn)
static int iscsi_sw_tcp_pdu_xmit(struct iscsi_task *task)
{
struct iscsi_conn *conn = task->conn;
- int rc;
+ unsigned long pflags = current->flags;
+ int rc = 0;
+
+ current->flags |= PF_MEMALLOC;
while (iscsi_sw_tcp_xmit_qlen(conn)) {
rc = iscsi_sw_tcp_xmit(conn);
- if (rc == 0)
- return -EAGAIN;
+ if (rc == 0) {
+ rc = -EAGAIN;
+ break;
+ }
if (rc < 0)
- return rc;
+ break;
+ rc = 0;
}
- return 0;
+ tsk_restore_flags(current, pflags, PF_MEMALLOC);
+ return rc;
}
/*
@@ -665,6 +672,7 @@ iscsi_sw_tcp_conn_bind(struct iscsi_cls_session *cls_session,
sk->sk_reuse = 1;
sk->sk_sndtimeo = 15 * HZ; /* FIXME: make it configurable */
sk->sk_allocation = GFP_ATOMIC;
+ sk_set_memalloc(sk);
iscsi_sw_tcp_conn_set_callbacks(conn);
tcp_sw_conn->sendpage = tcp_sw_conn->sock->ops->sendpage;
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread