From: Mike Snitzer <snitzer@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-scsi@vger.kernel.org, babu.moger@netapp.com, hare@suse.de,
michaelc@cs.wisc.edu, James.Bottomley@hansenpartnership.com,
stable@vger.kernel.org.#.3.4
Subject: Re: scsi_lib: fix scsi_io_completion's SG_IO error propagation
Date: Thu, 31 May 2012 16:24:22 -0400 [thread overview]
Message-ID: <20120531202422.GA8731@redhat.com> (raw)
In-Reply-To: <4FC7CBCA.60707@redhat.com>
On Thu, May 31 2012 at 3:51pm -0400,
Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 31/05/2012 21:05, Mike Snitzer ha scritto:
> > The following v3.4-rc1 commit unmasked an existing bug in
> > scsi_io_completion's SG_IO error handling:
> > 47ac56d [SCSI] scsi_error: classify some ILLEGAL_REQUEST sense as a permanent TARGET_ERROR
> >
> > Given that certain ILLEGAL_REQUEST are now properly categorized as
> > TARGET_ERROR the host_byte is being set (before host_byte wasn't ever
> > set for these ILLEGAL_REQUEST).
> >
> > In scsi_io_completion, initialize req->errors with cmd->result _after_
> > the SG_IO block that calls __scsi_error_from_host_byte (which may
> > modify the host_byte).
> >
> > Before this fix:
> >
> > cdb to send: 12 01 01 00 00 00
> > ioctl(3, SG_IO, {'S', SG_DXFER_NONE, cmd[6]=[12, 01, 01, 00, 00, 00],
> > mx_sb_len=32, iovec_count=0, dxfer_len=0, timeout=20000, flags=0,
> > status=02, masked_status=01, sb[19]=[70, 00, 05, 00, 00, 00, 00, 0b,
> > 00, 00, 00, 00, 24, 00, 00, 00, 00, 00, 00], host_status=0x10,
> > driver_status=0x8, resid=0, duration=0, info=0x1}) = 0
> > SCSI Status: Check Condition
> >
> > Sense Information:
> > sense buffer empty
> >
> > After:
> >
> > cdb to send: 12 01 01 00 00 00
> > ioctl(3, SG_IO, {'S', SG_DXFER_NONE, cmd[6]=[12, 01, 01, 00, 00, 00],
> > mx_sb_len=32, iovec_count=0, dxfer_len=0, timeout=20000, flags=0,
> > status=02, masked_status=01, sb[19]=[70, 00, 05, 00, 00, 00, 00, 0b,
> > 00, 00, 00, 00, 24, 00, 00, 00, 00, 00, 00], host_status=0,
> > driver_status=0x8, resid=0, duration=0, info=0x1}) = 0
> > SCSI Status: Check Condition
> >
> > Sense Information:
> > Fixed format, current; Sense key: Illegal Request
> > Additional sense: Invalid field in cdb
> > Raw sense data (in hex):
> > 70 00 05 00 00 00 00 0b 00 00 00 00 24 00 00 00
> > 00 00 00
> >
> > Signed-off-by: Mike Snitzer <snitzer@redhat.com>
> > Reviewed-by: Babu Moger <babu.moger@netapp.com>
>
> Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> Tested-by: Paolo Bonzini <pbonzini@redhat.com>
Yes, thanks for backfilling the Reported-by and Tested-by Paolo!
next prev parent reply other threads:[~2012-05-31 20:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 19:05 [PATCH] [SCSI] scsi_lib: fix scsi_io_completion's SG_IO error propagation Mike Snitzer
2012-05-31 19:51 ` Paolo Bonzini
2012-05-31 20:24 ` Mike Snitzer [this message]
2012-05-31 20:33 ` Moger, Babu
2012-07-18 23:06 ` Mike Snitzer
2012-07-25 17:46 ` [RESEND PATCH] SCSI: " Mike Snitzer
2012-07-27 13:29 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120531202422.GA8731@redhat.com \
--to=snitzer@redhat.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=babu.moger@netapp.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org.#.3.4 \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).