From: Matthew Wilcox <matthew@wil.cx>
To: James Bottomley <jbottomley@parallels.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
Alex Iannicelli <alex.iannicelli@emulex.com>,
James Smart <james.smart@emulex.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: lpfc: problems with -Werror
Date: Fri, 22 Jun 2012 12:46:26 -0600 [thread overview]
Message-ID: <20120622184626.GA3536@parisc-linux.org> (raw)
In-Reply-To: <1340265001.2985.13.camel@dabdike.int.hansenpartnership.com>
On Thu, Jun 21, 2012 at 07:50:02AM +0000, James Bottomley wrote:
> @@ -22,7 +22,9 @@
> ccflags-$(GCOV) := -fprofile-arcs -ftest-coverage
> ccflags-$(GCOV) += -O0
>
> +ifdef WARNINGS_BECOME_ERRORS
> ccflags-y += -Werror
> +endif
>
> obj-$(CONFIG_SCSI_LPFC) := lpfc.o
Why not more simply:
ccflags-$(WARNINGS_BECOME_ERRORS) += -Werror
> N?????r??y????b?X????v?^?)??{.n?+????{???"?{ay?\x1d
?????,j\a??f???h???z?\x1e
?w???\f
???j:+v???w?j?m????\a????zZ+???????j"??!
That's some nasty line noise on your modem there, James.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2012-06-22 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 1:30 lpfc: problems with -Werror Fengguang Wu
2012-06-21 7:50 ` James Bottomley
2012-06-22 18:46 ` Matthew Wilcox [this message]
2012-06-22 21:58 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120622184626.GA3536@parisc-linux.org \
--to=matthew@wil.cx \
--cc=alex.iannicelli@emulex.com \
--cc=fengguang.wu@intel.com \
--cc=james.smart@emulex.com \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox