From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch -resend] [SCSI] megaraid: remove a spurious IRQ enable Date: Wed, 27 Jun 2012 12:00:30 +0300 Message-ID: <20120627090030.GC31212@elgon.mountain> References: <20120627085800.GA3007@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20120627085800.GA3007@mwanda> Sender: linux-kernel-owner@vger.kernel.org To: Neela Syam Kolli Cc: "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christoph Hellwig List-Id: linux-scsi@vger.kernel.org We took this lock with spin_lock() so we should unlock it with spin_unlock() instead of spin_unlock_irq(). This was introduced in f2c8dc402b "[SCSI] megaraid_mbox: remove scsi_assign_lock usage". Signed-off-by: Dan Carpenter --- This was originally sent on Sat, 30 Jul 2011. I have cleaned up the commit message a bit and added Christoph to the CC list. diff --git a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c index 35bd138..54b1c5b 100644 --- a/drivers/scsi/megaraid/megaraid_mbox.c +++ b/drivers/scsi/megaraid/megaraid_mbox.c @@ -2731,7 +2731,7 @@ megaraid_reset_handler(struct scsi_cmnd *scp) } out: - spin_unlock_irq(&adapter->lock); + spin_unlock(&adapter->lock); return rval; }