linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Pitt <martin.pitt@ubuntu.com>
To: Randy Dunlap <rdunlap@xenotime.net>,
	Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	David Zeuthen <zeuthen@gmail.com>, Kay Sievers <kay@vrfy.org>
Subject: Re: [PATCH 1/1] [SCSI] scsi_debug: Add "removable" parameter
Date: Wed, 27 Jun 2012 15:01:16 +0200	[thread overview]
Message-ID: <20120627130116.GA3307@piware.de> (raw)
In-Reply-To: <1647133.Oeh9OMjxKH@donald.sf-tec.de> <4FCE30DE.6090903@xenotime.net>

Hello Randy, Eike,

Randy Dunlap [2012-06-05  9:16 -0700]:
> so why not make it a bool instead of an int value?

Rolf Eike Beer [2012-06-05 20:10 +0200]:
> This is wrong. Signed-off would mean that he takes the patch and passed it on. 
> So what this really is as you as the original author push this out is either 
> Acked-by, Tested-by, Reviewed-by or something like that.

I did not hear any other feedback, so I'm resending the patch with
these two changes.

Thanks,

Martin



-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

  parent reply	other threads:[~2012-06-27 13:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-05  7:25 [PATCH 0/1] Option for scsi_debug to fake removable devices Martin Pitt
2012-06-05  7:27 ` [PATCH 1/1] [SCSI] scsi_debug: Add "removable" parameter Martin Pitt
2012-06-05 16:16   ` Randy Dunlap
2012-06-05 17:39     ` Martin Pitt
2012-06-27 13:01     ` Martin Pitt [this message]
2012-06-05 18:10 ` [PATCH 0/1] Option for scsi_debug to fake removable devices Rolf Eike Beer
2012-06-06  4:08   ` Martin Pitt
2012-06-27 13:03 ` [PATCH v2 1/1] [SCSI] scsi_debug: Add "removable" parameter Martin Pitt
  -- strict thread matches above, loose matches on Subject: below --
2012-07-10  9:22 [PATCH 0/1] Option for scsi_debug to fake removable devices Martin Pitt
2012-07-10  9:24 ` [PATCH 1/1] [SCSI] scsi_debug: Add "removable" parameter Martin Pitt
2012-09-06 10:03 [PATCH 0/1] Option for scsi_debug to fake removable devices Martin Pitt
2012-09-06 10:04 ` [PATCH 1/1] [SCSI] scsi_debug: Add "removable" parameter Martin Pitt
2012-09-06 14:22   ` Douglas Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120627130116.GA3307@piware.de \
    --to=martin.pitt@ubuntu.com \
    --cc=eike-kernel@sf-tec.de \
    --cc=kay@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=zeuthen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).