From: majianpeng <majianpeng@gmail.com>
To: 于向亮 <yuxiangl@marvell.com>,
"scsi maintainers" <JBottomley@parallels.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: RE: [PATCH] scsi/mvsas: Fix oops when ata command timeout.
Date: Thu, 2 Aug 2012 13:13:03 +0800 [thread overview]
Message-ID: <201208021312245004210@gmail.com> (raw)
In-Reply-To: F766E4F80769BD478052FB6533FA745D1A58530359@SC-VEXCH4.marvell.com
On 2012-08-01 19:21 Xiangliang Yu <yuxiangl@marvell.com> Wrote:
>Hi, Jianpeng
>
>I think MVSAS shouldn't care the completion sign here, just modify task state is ok.
>
>
>
[snip]
>>
>> Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
>> ---
>> drivers/scsi/mvsas/mv_sas.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
>> index 4539d59..af6a1c5 100644
>> --- a/drivers/scsi/mvsas/mv_sas.c
>> +++ b/drivers/scsi/mvsas/mv_sas.c
>> @@ -1629,7 +1629,10 @@ int mvs_abort_task(struct sas_task *task)
>> mv_dprintk("mvs_abort_task() mvi=%p task=%p "
>> "slot=%p slot_idx=x%x\n",
>> mvi, task, slot, slot_idx);
>> - mvs_tmf_timedout((unsigned long)task);
>> + if (task->slow_task != NULL)
>> + mvs_tmf_timedout((unsigned long)task);
>> + else
>> + task->task_state_flags |= SAS_TASK_STATE_ABORTED;
>> mvs_slot_task_free(mvi, task, slot, slot_idx);
>> rc = TMF_RESP_FUNC_COMPLETE;
>> goto out;
>> --
>> 1.7.9.5
Thanks, I'll modify the code and resend.
prev parent reply other threads:[~2012-08-02 5:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 7:14 [PATCH] scsi/mvsas: Fix oops when ata command timeout majianpeng
2012-08-01 11:21 ` Xiangliang Yu
2012-08-02 5:13 ` majianpeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208021312245004210@gmail.com \
--to=majianpeng@gmail.com \
--cc=JBottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=yuxiangl@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).