From: Andi Kleen <ak@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: + sections-fix-section-conflicts-in-drivers-scsi.patch added to -mm tree
Date: Fri, 14 Sep 2012 07:18:21 -0700 [thread overview]
Message-ID: <20120914141821.GG4092@tassilo.jf.intel.com> (raw)
In-Reply-To: <1347631429.2450.11.camel@dabdike.int.hansenpartnership.com>
On Fri, Sep 14, 2012 at 03:03:49PM +0100, James Bottomley wrote:
> On Fri, 2012-09-14 at 06:50 -0700, Andi Kleen wrote:
> > > > ------------------------------------------------------
> > > > From: Andi Kleen <ak@linux.intel.com>
> > > > Subject: sections: fix section conflicts in drivers/scsi
> > >
> > > NAK this, please. We're fixing all of this by removing CONFIG_HOTPLUG,
> > > so all __dev annotations become nops and there's little point changing
> > > any.
> >
> > I would prefer to still put it in because it fixes my compilation.
> > You can still remove them then, but it's better to fix it first.
>
> Just for curiosity, how? You're compiling for x86-64, right? There
I compile allyes (and also random/no/normal/rhel6/opensuse configs) on 32bit
and 64bit. Most of the section fixes I did showed up as actual errors,
but I also did some greping some time ago, so there may be a few changes
in dead code. However the majority was live.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
prev parent reply other threads:[~2012-09-14 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120913233742.7287E100047@wpzn3.hot.corp.google.com>
2012-09-14 8:04 ` + sections-fix-section-conflicts-in-drivers-scsi.patch added to -mm tree James Bottomley
2012-09-14 13:50 ` Andi Kleen
2012-09-14 14:03 ` James Bottomley
2012-09-14 14:18 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914141821.GG4092@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox