linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Bj??rn Mork <bjorn@mork.no>
Cc: sreekanth.reddy@lsi.com, linux-scsi@vger.kernel.org,
	jejb@kernel.org, Nagalakshmi.Nandigama@lsi.com,
	Sathya.Prakash@lsi.com
Subject: Re: [PATCH][SCSI] mpt3sas: Paer 1 of MPI API headers
Date: Sat, 29 Sep 2012 19:50:28 -0600	[thread overview]
Message-ID: <20120930015027.GA28918@parisc-linux.org> (raw)
In-Reply-To: <878vbsy2jg.fsf@nemi.mork.no>

On Sat, Sep 29, 2012 at 10:52:50PM +0200, Bj??rn Mork wrote:
> <sreekanth.reddy@lsi.com> writes:
> > This patch contains MPI API headers
> 
> Why can't this and the other headers be shared between the mpt2sas and
> mpt3sas drivers?  Looks like you are duplicating a lot of code already
> present in drivers/scsi/mpt2sas.  Why?  That's a recipe for maintenance
> hell...

I would go further and ask why this needs a new driver; why can't mpt2sas
be enhanced to drive the 12Gbit cards?

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

  reply	other threads:[~2012-09-30  2:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-29 14:07 [PATCH][SCSI] mpt3sas: Paer 1 of MPI API headers sreekanth.reddy
2012-09-29 20:52 ` Bjørn Mork
2012-09-30  1:50   ` Matthew Wilcox [this message]
2012-10-02 15:19     ` Nandigama, Nagalakshmi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120930015027.GA28918@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=Nagalakshmi.Nandigama@lsi.com \
    --cc=Sathya.Prakash@lsi.com \
    --cc=bjorn@mork.no \
    --cc=jejb@kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sreekanth.reddy@lsi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).