From: "Richard W.M. Jones" <rjones@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.
Date: Mon, 1 Oct 2012 14:18:59 +0100 [thread overview]
Message-ID: <20121001131859.GC24071@rhmail.home.annexia.org> (raw)
In-Reply-To: <506996DD.30300@redhat.com>
On Mon, Oct 01, 2012 at 03:13:01PM +0200, Paolo Bonzini wrote:
> Il 20/08/2012 16:05, Paolo Bonzini ha scritto:
> > Il 20/08/2012 16:04, Richard W.M. Jones ha scritto:
> >> From: "Richard W.M. Jones" <rjones@redhat.com>
> >>
> >> The sg struct is used without being initialized.
> >>
> >> https://bugzilla.redhat.com/show_bug.cgi?id=847548
> >>
> >> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> >> ---
> >> drivers/scsi/virtio_scsi.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
> >> index c7030fb..8a66f83 100644
> >> --- a/drivers/scsi/virtio_scsi.c
> >> +++ b/drivers/scsi/virtio_scsi.c
> >> @@ -219,7 +219,7 @@ static int virtscsi_kick_event(struct virtio_scsi *vscsi,
> >> struct scatterlist sg;
> >> unsigned long flags;
> >>
> >> - sg_set_buf(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
> >> + sg_init_one(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
> >>
> >> spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags);
> >>
> >>
> >
> > Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> >
> > Paolo
> >
>
> Ping, is this patch going into 3.7?
I was a bit surprised to see this wasn't upstream since it's vital for
using virtio-scsi reliably (as well as being a one line fix for a
blatant bug).
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
next prev parent reply other threads:[~2012-10-01 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 14:04 [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure Richard W.M. Jones
2012-08-20 14:05 ` Paolo Bonzini
2012-10-01 13:13 ` Paolo Bonzini
2012-10-01 13:18 ` Richard W.M. Jones [this message]
2012-10-01 13:21 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121001131859.GC24071@rhmail.home.annexia.org \
--to=rjones@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).