[PATCH] Try #3: Use SCSI read/write(16) with > 32-bit LBA drives

[PATCH] Try #3: Use SCSI read/write(16) with > 32-bit LBA drives

[Jason J. Herne]

From: "Jason J. Herne" <hernejj@gmail.com>

Force large capacity (> 0xFFFFFFFF blocks) drives to use READ/WRITE(16) instead
of READ/WRITE(10). Some(most/all?) USB enclosures do not like READ(10) commands
when a large capacity drive is installed. This issue was reported and discussed
here: http://marc.info/?l=linux-usb&m=135247705222324&w=2

Signed-off-by: Jason J. Herne <hernejj@gmail.com>
---
 drivers/scsi/sd.c          |    4 +++-
 include/scsi/scsi_device.h |    1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 12f6fdf..f8eaf3a 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -887,7 +887,7 @@ static int sd_prep_fn(struct request_queue *q, struct request *rq)
 		SCpnt->cmnd[29] = (unsigned char) (this_count >> 16) & 0xff;
 		SCpnt->cmnd[30] = (unsigned char) (this_count >> 8) & 0xff;
 		SCpnt->cmnd[31] = (unsigned char) this_count & 0xff;
-	} else if (block > 0xffffffff) {
+	} else if (sdp->use_16_for_rw) {
 		SCpnt->cmnd[0] += READ_16 - READ_6;
 		SCpnt->cmnd[1] = protect | ((rq->cmd_flags & REQ_FUA) ? 0x8 : 0);
 		SCpnt->cmnd[2] = sizeof(block) > 4 ? (unsigned char) (block >> 56) & 0xff : 0;
@@ -2054,6 +2054,8 @@ got_data:
 		}
 	}
 
+	sdp->use_16_for_rw = (sdkp->capacity > 0xffffffff);
+
 	/* Rescale capacity to 512-byte units */
 	if (sector_size == 4096)
 		sdkp->capacity <<= 3;
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 88fae8d..19ab8f1 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -135,6 +135,7 @@ struct scsi_device {
 				     * because we did a bus reset. */
 	unsigned use_10_for_rw:1; /* first try 10-byte read / write */
 	unsigned use_10_for_ms:1; /* first try 10-byte mode sense/select */
+	unsigned use_16_for_rw:1; /* Use read/write(16) over read/write(10) */
 	unsigned skip_ms_page_8:1;	/* do not use MODE SENSE page 0x08 */
 	unsigned skip_ms_page_3f:1;	/* do not use MODE SENSE page 0x3f */
 	unsigned skip_vpd_pages:1;	/* do not read VPD pages */
-- 
1.7.9.5

Re: [PATCH] Try #3: Use SCSI read/write(16) with > 32-bit LBA drives

[Sergei Shtylyov]

Hello.

On 15-11-2012 2:03, Jason J. Herne wrote:

> From: "Jason J. Herne" <hernejj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

   You have already posted Try #3. And preferrably, information about patch 
version should be included with [PATCH] prefix like this [PATCH v4].

> Force large capacity (> 0xFFFFFFFF blocks) drives to use READ/WRITE(16) instead
> of READ/WRITE(10). Some(most/all?) USB enclosures do not like READ(10) commands
> when a large capacity drive is installed. This issue was reported and discussed
> here: http://marc.info/?l=linux-usb&m=135247705222324&w=2

> Signed-off-by: Jason J. Herne <hernejj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Try #3: Use SCSI read/write(16) with > 32-bit LBA drives

[Jason J. Herne]

On Wed, Nov 14, 2012 at 5:22 PM, Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org> wrote:
> Hello.
>
>
> On 15-11-2012 2:03, Jason J. Herne wrote:
>
>> From: "Jason J. Herne" <hernejj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
>
>   You have already posted Try #3. And preferrably, information about patch
> version should be included with [PATCH] prefix like this [PATCH v4].
>
>

Noted for future submissions.  Any idea how I get git send-email to
generate the patch tag
like that?

Also, do I need to resubmit this patch because of this semi-faulty
subject line? I would
assume that to be unnecessary.

--
- Jason J. Herne (hernejj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Try #3: Use SCSI read/write(16) with > 32-bit LBA drives

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]

Hi,

On Wed, Nov 14, 2012 at 08:06:20PM -0500, Jason J. Herne wrote:
> On Wed, Nov 14, 2012 at 5:22 PM, Sergei Shtylyov <sshtylyov@mvista.com> wrote:
> > Hello.
> >
> >
> > On 15-11-2012 2:03, Jason J. Herne wrote:
> >
> >> From: "Jason J. Herne" <hernejj@gmail.com>
> >
> >
> >   You have already posted Try #3. And preferrably, information about patch
> > version should be included with [PATCH] prefix like this [PATCH v4].
> >
> >
> 
> Noted for future submissions.  Any idea how I get git send-email to
> generate the patch tag
> like that?
> 
> Also, do I need to resubmit this patch because of this semi-faulty
> subject line? I would
> assume that to be unnecessary.

$ git send-email --subject-prefix="PATCH v4" HEAD ^origin/master

if you want to generate the patch file before sending, pass
--subject-prefix to git format-patch instead.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] Try #3: Use SCSI read/write(16) with > 32-bit LBA drives

[Christoph Hellwig]

On Wed, Nov 14, 2012 at 05:03:22PM -0500, Jason J. Herne wrote:
> From: "Jason J. Herne" <hernejj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> Force large capacity (> 0xFFFFFFFF blocks) drives to use READ/WRITE(16) instead
> of READ/WRITE(10). Some(most/all?) USB enclosures do not like READ(10) commands
> when a large capacity drive is installed. This issue was reported and discussed
> here: http://marc.info/?l=linux-usb&m=135247705222324&w=2

Is there any reason not to simply use the 16 byte command
unconditionally for large devices?

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Try #3: Use SCSI read/write(16) with > 32-bit LBA drives

[Jason J. Herne]

On Thu, Nov 15, 2012 at 4:20 AM, Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> wrote:
> On Wed, Nov 14, 2012 at 05:03:22PM -0500, Jason J. Herne wrote:
>> From: "Jason J. Herne" <hernejj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>
>> Force large capacity (> 0xFFFFFFFF blocks) drives to use READ/WRITE(16) instead
>> of READ/WRITE(10). Some(most/all?) USB enclosures do not like READ(10) commands
>> when a large capacity drive is installed. This issue was reported and discussed
>> here: http://marc.info/?l=linux-usb&m=135247705222324&w=2
>
> Is there any reason not to simply use the 16 byte command
> unconditionally for large devices?
>

What you are suggesting is exactly what this patch is doing.  Code was
added to sd_read_capacity()
to turn on the new bit if the device has more than 2^32 blocks.

--
- Jason J. Herne (hernejj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] Try #3: Use SCSI read/write(16) with > 32-bit LBA drives

[Jason J. Herne]

From: "Jason J. Herne" <hernejj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Force large capacity (> 0xFFFFFFFF blocks) drives to use READ/WRITE(16) instead
of READ/WRITE(10). Some(most/all?) USB enclosures do not like READ(10) commands
when a large capacity drive is installed.

Signed-off-by: Jason J. Herne <hernejj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/scsi/sd.c          |    5 ++++-
 include/scsi/scsi_device.h |    1 +
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 12f6fdf..f7913c0 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -887,7 +887,7 @@ static int sd_prep_fn(struct request_queue *q, struct request *rq)
 		SCpnt->cmnd[29] = (unsigned char) (this_count >> 16) & 0xff;
 		SCpnt->cmnd[30] = (unsigned char) (this_count >> 8) & 0xff;
 		SCpnt->cmnd[31] = (unsigned char) this_count & 0xff;
-	} else if (block > 0xffffffff) {
+	} else if (sdp->use_16_for_rw) {
 		SCpnt->cmnd[0] += READ_16 - READ_6;
 		SCpnt->cmnd[1] = protect | ((rq->cmd_flags & REQ_FUA) ? 0x8 : 0);
 		SCpnt->cmnd[2] = sizeof(block) > 4 ? (unsigned char) (block >> 56) & 0xff : 0;
@@ -2054,6 +2054,9 @@ got_data:
 		}
 	}
 
+	/* Use read/write(16) for > 32-bit LBA disks */
+	sdp->use_16_for_rw = (sdkp->capacity > 0xffffffff);
+
 	/* Rescale capacity to 512-byte units */
 	if (sector_size == 4096)
 		sdkp->capacity <<= 3;
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 88fae8d..19ab8f1 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -135,6 +135,7 @@ struct scsi_device {
 				     * because we did a bus reset. */
 	unsigned use_10_for_rw:1; /* first try 10-byte read / write */
 	unsigned use_10_for_ms:1; /* first try 10-byte mode sense/select */
+	unsigned use_16_for_rw:1; /* Use read/write(16) over read/write(10) */
 	unsigned skip_ms_page_8:1;	/* do not use MODE SENSE page 0x08 */
 	unsigned skip_ms_page_3f:1;	/* do not use MODE SENSE page 0x3f */
 	unsigned skip_vpd_pages:1;	/* do not read VPD pages */
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html