From: Cong Ding <dinggnu@gmail.com>
To: JBottomley@parallels.com, Achim Leubner <achim_leubner@adaptec.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi:gdth.c: fix compilation warning
Date: Sun, 9 Dec 2012 15:18:04 +0000 [thread overview]
Message-ID: <20121209151804.GB25293@gmail.com> (raw)
In-Reply-To: <1354529949-8483-1-git-send-email-dinggnu@gmail.com>
ping!
- cong
On Mon, Dec 03, 2012 at 10:19:09AM +0000, Cong Ding wrote:
> We do not allow old-style function definition. Always spell foo(void) if
> a function does not take any parameters.
>
> Signed-off-by: Cong Ding <dinggnu@gmail.com>
> ---
> drivers/scsi/gdth.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
> index 5d72274..950c095 100644
> --- a/drivers/scsi/gdth.c
> +++ b/drivers/scsi/gdth.c
> @@ -204,7 +204,7 @@ static char strbuf[MAX_SERBUF+1];
> #else
> #define COM_BASE 0x3f8
> #endif
> -static void ser_init()
> +static void ser_init(void)
> {
> unsigned port=COM_BASE;
>
> --
> 1.7.4.5
>
next prev parent reply other threads:[~2012-12-09 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 10:19 [PATCH] scsi:gdth.c: fix compilation warning Cong Ding
2012-12-09 15:18 ` Cong Ding [this message]
2013-01-18 21:01 ` Cong Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121209151804.GB25293@gmail.com \
--to=dinggnu@gmail.com \
--cc=JBottomley@parallels.com \
--cc=achim_leubner@adaptec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).