* [PATCH] scsi:gdth.c: fix compilation warning
@ 2012-12-03 10:19 Cong Ding
2012-12-09 15:18 ` Cong Ding
2013-01-18 21:01 ` Cong Ding
0 siblings, 2 replies; 3+ messages in thread
From: Cong Ding @ 2012-12-03 10:19 UTC (permalink / raw)
To: JBottomley, Achim Leubner; +Cc: linux-scsi, linux-kernel, Cong Ding
We do not allow old-style function definition. Always spell foo(void) if
a function does not take any parameters.
Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
drivers/scsi/gdth.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index 5d72274..950c095 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -204,7 +204,7 @@ static char strbuf[MAX_SERBUF+1];
#else
#define COM_BASE 0x3f8
#endif
-static void ser_init()
+static void ser_init(void)
{
unsigned port=COM_BASE;
--
1.7.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi:gdth.c: fix compilation warning
2012-12-03 10:19 [PATCH] scsi:gdth.c: fix compilation warning Cong Ding
@ 2012-12-09 15:18 ` Cong Ding
2013-01-18 21:01 ` Cong Ding
1 sibling, 0 replies; 3+ messages in thread
From: Cong Ding @ 2012-12-09 15:18 UTC (permalink / raw)
To: JBottomley, Achim Leubner; +Cc: linux-scsi, linux-kernel
ping!
- cong
On Mon, Dec 03, 2012 at 10:19:09AM +0000, Cong Ding wrote:
> We do not allow old-style function definition. Always spell foo(void) if
> a function does not take any parameters.
>
> Signed-off-by: Cong Ding <dinggnu@gmail.com>
> ---
> drivers/scsi/gdth.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
> index 5d72274..950c095 100644
> --- a/drivers/scsi/gdth.c
> +++ b/drivers/scsi/gdth.c
> @@ -204,7 +204,7 @@ static char strbuf[MAX_SERBUF+1];
> #else
> #define COM_BASE 0x3f8
> #endif
> -static void ser_init()
> +static void ser_init(void)
> {
> unsigned port=COM_BASE;
>
> --
> 1.7.4.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi:gdth.c: fix compilation warning
2012-12-03 10:19 [PATCH] scsi:gdth.c: fix compilation warning Cong Ding
2012-12-09 15:18 ` Cong Ding
@ 2013-01-18 21:01 ` Cong Ding
1 sibling, 0 replies; 3+ messages in thread
From: Cong Ding @ 2013-01-18 21:01 UTC (permalink / raw)
To: JBottomley, Achim Leubner
Cc: linux-scsi, Linux Kernel Mailing List, Cong Ding, sfr,
Greg Kroah-Hartman
Hi all, is this still in the queue or...?
- cong
On Mon, Dec 3, 2012 at 11:19 AM, Cong Ding <dinggnu@gmail.com> wrote:
> We do not allow old-style function definition. Always spell foo(void) if
> a function does not take any parameters.
>
> Signed-off-by: Cong Ding <dinggnu@gmail.com>
> ---
> drivers/scsi/gdth.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
> index 5d72274..950c095 100644
> --- a/drivers/scsi/gdth.c
> +++ b/drivers/scsi/gdth.c
> @@ -204,7 +204,7 @@ static char strbuf[MAX_SERBUF+1];
> #else
> #define COM_BASE 0x3f8
> #endif
> -static void ser_init()
> +static void ser_init(void)
> {
> unsigned port=COM_BASE;
>
> --
> 1.7.4.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-18 21:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-03 10:19 [PATCH] scsi:gdth.c: fix compilation warning Cong Ding
2012-12-09 15:18 ` Cong Ding
2013-01-18 21:01 ` Cong Ding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).