From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Thumshirn Subject: Re: [PATCH -resend 1/1] fcoe: use continue instead of goto+label Date: Tue, 06 Oct 2015 14:29:51 +0200 Message-ID: <2012401.0lbOR2Ajn3@c203> References: <1444134465-3693-1-git-send-email-jslaby@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1444134465-3693-1-git-send-email-jslaby-AlSwsSmVLrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fcoe-devel-bounces-s9riP+hp16TNLxjTenLetw@public.gmane.org Sender: "fcoe-devel" To: Jiri Slaby Cc: linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, JBottomley-wo1vFcy6AUs@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kxie-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org, fcoe-devel-s9riP+hp16TNLxjTenLetw@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org List-Id: linux-scsi@vger.kernel.org On Tuesday 06 October 2015 14:27:45 Jiri Slaby wrote: > There is a label pointing to the start of a while loop and a goto > nested only in the loop. The goto jumps to the label in some cases. > Replace the goto and the label by simple continue. > = > Signed-off-by: Jiri Slaby > Cc: Robert Love > Cc: fcoe-devel-s9riP+hp16TNLxjTenLetw@public.gmane.org > --- > Sent on: > May 5 > = > drivers/scsi/fcoe/fcoe.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > = > diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c > index d3eb80c46bbe..d187ba9b361d 100644 > --- a/drivers/scsi/fcoe/fcoe.c > +++ b/drivers/scsi/fcoe/fcoe.c > @@ -1873,7 +1873,6 @@ static int fcoe_percpu_receive_thread(void *arg) > = > set_user_nice(current, MIN_NICE); > = > -retry: > while (!kthread_should_stop()) { > = > spin_lock_bh(&p->fcoe_rx_list.lock); > @@ -1883,7 +1882,7 @@ retry: > set_current_state(TASK_INTERRUPTIBLE); > spin_unlock_bh(&p->fcoe_rx_list.lock); > schedule(); > - goto retry; > + continue; > } > = > spin_unlock_bh(&p->fcoe_rx_list.lock); Reviewed-by: Johannes Thumshirn -- = Johannes Thumshirn Storage jthumshirn-l3A5Bk7waGM@public.gmane.org +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton HRB 21284 (AG N=FCrnberg) Key fingerprint =3D EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850