* [PATCH 0/1] Fix several unlock issues in ipr driver
@ 2013-01-02 22:26 wenxiong
2013-01-02 22:26 ` [PATCH 1/1] ipr: " wenxiong
0 siblings, 1 reply; 3+ messages in thread
From: wenxiong @ 2013-01-02 22:26 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, klebers, brking
The patch fixed several unlock issues in ipr driver.
Thanks,
Wendy
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] ipr: Fix several unlock issues in ipr driver
2013-01-02 22:26 [PATCH 0/1] Fix several unlock issues in ipr driver wenxiong
@ 2013-01-02 22:26 ` wenxiong
2013-01-02 22:36 ` Brian King
0 siblings, 1 reply; 3+ messages in thread
From: wenxiong @ 2013-01-02 22:26 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, klebers, brking, Wen Xiong
[-- Attachment #1: lock_bugs --]
[-- Type: text/plain, Size: 1082 bytes --]
This patch fixes several unlock issues in ipr driver.
Signed-off-by: Wen Xiong <wenxiong@linux.vnet.ibm.com>
---
drivers/scsi/ipr.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Index: b/drivers/scsi/ipr.c
===================================================================
--- a/drivers/scsi/ipr.c 2013-01-02 15:10:03.000000000 -0600
+++ b/drivers/scsi/ipr.c 2013-01-02 15:13:49.572476277 -0600
@@ -4985,8 +4985,8 @@ static int __ipr_eh_dev_reset(struct scs
ipr_cmd->qc->flags |= ATA_QCFLAG_FAILED;
}
}
- spin_unlock(&hrrq->_lock);
}
+ spin_unlock(&hrrq->_lock);
}
res->resetting_device = 1;
scmd_printk(KERN_ERR, scsi_cmd, "Resetting device\n");
@@ -5006,8 +5006,8 @@ static int __ipr_eh_dev_reset(struct scs
rc = -EIO;
break;
}
- spin_unlock(&hrrq->_lock);
}
+ spin_unlock(&hrrq->_lock);
}
} else
rc = ipr_device_reset(ioa_cfg, res);
@@ -6663,6 +6663,7 @@ static unsigned int ipr_qc_issue(struct
default:
WARN_ON(1);
+ spin_unlock(&ipr_cmd->hrrq->_lock);
return AC_ERR_INVALID;
}
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ipr: Fix several unlock issues in ipr driver
2013-01-02 22:26 ` [PATCH 1/1] ipr: " wenxiong
@ 2013-01-02 22:36 ` Brian King
0 siblings, 0 replies; 3+ messages in thread
From: Brian King @ 2013-01-02 22:36 UTC (permalink / raw)
To: wenxiong; +Cc: James.Bottomley, linux-scsi, klebers
On 01/02/2013 04:26 PM, wenxiong@linux.vnet.ibm.com wrote:
> This patch fixes several unlock issues in ipr driver.
James - this fixes a couple regressions that were introduced in
the previous patch set.
Acked-by: Brian King <brking@linux.vnet.ibm.com>
--
Brian King
Power Linux I/O
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-02 22:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-02 22:26 [PATCH 0/1] Fix several unlock issues in ipr driver wenxiong
2013-01-02 22:26 ` [PATCH 1/1] ipr: " wenxiong
2013-01-02 22:36 ` Brian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).