From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] target: change sprintf to snprintf
Date: Sat, 19 Jan 2013 00:35:14 +0300 [thread overview]
Message-ID: <20130118213514.GO16282@mwanda> (raw)
In-Reply-To: <1358537812.18551.446.camel@haakon2.linux-iscsi.org>
On Fri, Jan 18, 2013 at 11:36:52AM -0800, Nicholas A. Bellinger wrote:
> On Fri, 2013-01-18 at 16:05 +0300, Dan Carpenter wrote:
> > "buf" is 128 characters and "vpd->device_identifier" is 256. It makes
> > the static checkers complain.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
>
> Applied to target-pending/for-next.
>
> > Probably we should just raise VPD_TMP_BUF_SIZE to 300.
>
> Also bumping up VPD_TMP_BUF_SIZE to 254 to match the usage with
> INQUIRY_VPD_DEVICE_IDENTIFIER_LEN sized vpd->device_identifier[] below.
>
It could still go over 254 because it's "T10 VPD Binary Device
Identifier: " plus INQUIRY_VPD_DEVICE_IDENTIFIER_LEN. But I agree
that probably 254 is enough space.
regards,
dan carpenter
prev parent reply other threads:[~2013-01-18 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 13:05 [patch] target: change sprintf to snprintf Dan Carpenter
2013-01-18 19:36 ` Nicholas A. Bellinger
2013-01-18 21:35 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118213514.GO16282@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox