Re: [Patch 1/1] cciss: bug fix, prevent cciss from loading in kdump kernel

Andrew Morton
2013-04-17T22:02:28Z

On Mon, 15 Apr 2013 12:59:06 -0500 Mike Miller <mike.miller@hp.com> wrote:

> Patch 1/1
>
> If hpsa is selected as the Smart Array driver cciss may try to load in the
> kdump kernel. When this happens kdump fails and a core file cannot be created.
> This patch prevents cciss from trying to load in this scenario. This effects
> primarily older Smart Array controllers.
>
> ...
>
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -4960,6 +4960,12 @@ static int cciss_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> ctlr_info_t *h;
> unsigned long flags;
>
> + /*
> + * if this is the kdump kernel and the user has set the flags to
> + * use hpsa rather than cciss just bail
> + */
> + if ((reset_devices) && (cciss_allow_hpsa == 1))
> + return -ENODEV;

OK, wazzup. That's the only occurrence of the symbol
"cciss_allow_hpsa" in Linux and needless to say, the compiler laughed
at me.