From: Dan Carpenter <dan.carpenter@oracle.com>
To: draviv@codeaurora.org
Cc: linux-scsi@vger.kernel.org, kbuild@01.org
Subject: re: [SCSI] ufs: add support for query requests
Date: Tue, 7 May 2013 17:25:41 +0300 [thread overview]
Message-ID: <20130507142540.GA20764@elgon.mountain> (raw)
Hello Dolev Raviv,
This is a semi-automatic email about new static checker warnings.
The patch 3aee47c623a3: "[SCSI] ufs: add support for query requests"
from May 2, 2013, leads to the following Smatch complaint:
drivers/scsi/ufs/ufshcd.c:723 ufshcd_query_request()
error: we previously assumed 'hba' could be null (see line 722)
drivers/scsi/ufs/ufshcd.c
721
722 if (!hba || !query || !response) {
^^^^
New check.
723 dev_err(hba->dev,
^^^^^^^^
New dereference.
724 "%s: NULL pointer hba = %p, query = %p response = %p\n",
725 __func__, hba, query, response);
regards,
dan carpenter
next reply other threads:[~2013-05-07 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 14:25 Dan Carpenter [this message]
2013-05-07 22:03 ` [SCSI] ufs: add support for query requests James Bottomley
2013-05-08 6:27 ` Dolev Raviv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130507142540.GA20764@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=draviv@codeaurora.org \
--cc=kbuild@01.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox