From: Kyle McMartin <kyle@infradead.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi@vger.kernel.org, yuxiangl@marvell.com
Subject: Re: [PATCH trivial] mvsas: fix build warning about enum comparisons
Date: Wed, 8 May 2013 09:49:52 -0400 [thread overview]
Message-ID: <20130508134952.GD20643@bombadil.infradead.org> (raw)
In-Reply-To: <1367961637.4108.15.camel@dabdike>
On Tue, May 07, 2013 at 02:20:37PM -0700, James Bottomley wrote:
> On Tue, 2013-05-07 at 12:57 -0400, Kyle McMartin wrote:
> > device_type is a sas_device_type, not a sas_dev_type.
>
> Heh, months ago, someone who submitted the same trivial but insufficient
> fix was asked to go and see if they could unify sas_device_type and
> sas_dev_type, which is the correct fix. They were never heard from
> again. I suppose that shows that if you want something doing properly,
> you should do it yourself.
>
Woops, sorry James, I only looked at the last two months of archives for
mvsas patches.
Thanks for fixing this.
regards, Kyle
prev parent reply other threads:[~2013-05-08 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 16:57 [PATCH trivial] mvsas: fix build warning about enum comparisons Kyle McMartin
2013-05-07 21:20 ` James Bottomley
2013-05-08 13:49 ` Kyle McMartin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130508134952.GD20643@bombadil.infradead.org \
--to=kyle@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=yuxiangl@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox