From: Christoph Hellwig <hch@lst.de>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Roland Dreier <roland@kernel.org>,
Kent Overstreet <koverstreet@google.com>,
Asias He <asias@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Moussa Ba <moussaba@micron.com>
Subject: Re: [PATCH 4/9] target: Avoid extra t_state_lock access in __target_execute_cmd
Date: Sat, 8 Jun 2013 08:32:12 +0200 [thread overview]
Message-ID: <20130608063212.GA27598@lst.de> (raw)
In-Reply-To: <1370640864-15568-5-git-send-email-nab@linux-iscsi.org>
On Fri, Jun 07, 2013 at 09:34:19PM +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@linux-iscsi.org>
>
> This patch makes target_execute_cmd() set CMD_T_BUSY|CMD_T_SENT while
> holding se_cmd->t_state_lock, in order to avoid the extra aquire/release
> in __target_execute_cmd().
Can you also do an audit that we actually still need all these flags?
I'm pretty sure there's a fair amount of duplication between all the t_state
and transport_state flags that could be rationalized.
next prev parent reply other threads:[~2013-06-08 6:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 21:34 [PATCH 0/9] target: Optimizations + cleanups for v3.11 Nicholas A. Bellinger
2013-06-07 21:34 ` [PATCH 1/9] target: Add transport_cmd_check_stop write_pending bit Nicholas A. Bellinger
2013-06-08 4:00 ` Jörn Engel
2013-06-08 6:29 ` Christoph Hellwig
2013-06-07 21:34 ` [PATCH 2/9] target: Drop unnecessary CMD_T_DEV_ACTIVE check from transport_lun_remove_cmd Nicholas A. Bellinger
2013-06-07 21:34 ` [PATCH 3/9] target: Remove legacy t_fe_count + avoid t_state_lock access in transport_put_cmd Nicholas A. Bellinger
2013-06-07 21:34 ` [PATCH 4/9] target: Avoid extra t_state_lock access in __target_execute_cmd Nicholas A. Bellinger
2013-06-08 6:32 ` Christoph Hellwig [this message]
2013-06-07 21:34 ` [PATCH 5/9] target: Drop unnecessary t_state_lock access for SCF_SUPPORTED_SAM_OPCODE assignment Nicholas A. Bellinger
2013-06-07 21:34 ` [PATCH 6/9] iscsi-target: Avoid unnecessary t_state_lock during unsolicited data-out check Nicholas A. Bellinger
2013-06-07 21:34 ` [PATCH 7/9] target: Drop legacy se_cmd->check_release bit Nicholas A. Bellinger
2013-06-07 21:34 ` [PATCH 8/9] vhost/scsi: Drop unnecessary wait_for_tasks=true usage with transport_generic_free_cmd Nicholas A. Bellinger
2013-06-27 1:59 ` Asias He
2013-06-07 21:34 ` [PATCH 9/9] vhost/scsi: Convert to se_cmd->cmd_kref TARGET_SCF_ACK_KREF usage Nicholas A. Bellinger
2013-06-27 1:59 ` Asias He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130608063212.GA27598@lst.de \
--to=hch@lst.de \
--cc=asias@redhat.com \
--cc=koverstreet@google.com \
--cc=linux-scsi@vger.kernel.org \
--cc=moussaba@micron.com \
--cc=mst@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=ogerlitz@mellanox.com \
--cc=roland@kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).