From: Dan Carpenter <dan.carpenter@oracle.com>
To: atul.deshmukh@qlogic.com
Cc: linux-scsi@vger.kernel.org
Subject: re: [SCSI] qla2xxx: Add support for ISP8044.
Date: Mon, 2 Sep 2013 12:20:30 +0300 [thread overview]
Message-ID: <20130902092030.GC30037@elgon.mountain> (raw)
Hello Atul Deshmukh,
This is a semi-automatic email about new static checker warnings.
The patch ef4647420025: "[SCSI] qla2xxx: Add support for ISP8044."
from Aug 27, 2013, leads to the following Smatch complaint:
drivers/scsi/qla2xxx/qla_os.c:2962 qla2x00_probe_one()
error: we previously assumed 'base_vha' could be null (see line 2632)
drivers/scsi/qla2xxx/qla_os.c
2631 base_vha = qla2x00_create_host(sht, ha);
2632 if (!base_vha) {
^^^^^^^^
Existing check.
2633 ret = -ENOMEM;
2634 qla2x00_mem_free(ha);
2635 qla2x00_free_req_que(ha, req);
2636 qla2x00_free_rsp_que(ha, rsp);
2637 goto probe_hw_failed;
2638 }
[ snip ]
2954 probe_hw_failed:
2955 if (IS_QLA82XX(ha)) {
2956 qla82xx_idc_lock(ha);
2957 qla82xx_clear_drv_active(ha);
2958 qla82xx_idc_unlock(ha);
2959 }
2960 if (IS_QLA8044(ha)) {
2961 qla8044_idc_lock(ha);
2962 qla8044_clear_drv_active(base_vha);
^^^^^^^^
Patch adds dereference.
2963 qla8044_idc_unlock(ha);
2964 }
regards,
dan carpenter
next reply other threads:[~2013-09-02 9:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 9:20 Dan Carpenter [this message]
2013-09-03 20:19 ` [SCSI] qla2xxx: Add support for ISP8044 Chad Dupuis
-- strict thread matches above, loose matches on Subject: below --
2013-11-01 10:30 Dan Carpenter
2013-11-05 9:20 ` Saurav Kashyap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130902092030.GC30037@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=atul.deshmukh@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox