From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
James Bottomley <jbottomley@parallels.com>,
linux-scsi@vger.kernel.org, Ewan Milne <emilne@redhat.com>,
Ren Mingxin <renmx@cn.fujitsu.com>, Joern Engel <joern@logfs.org>,
James Smart <james.smart@emulex.com>,
Bart Van Assche <bvanassche@acm.org>,
Roland Dreier <roland@purestorage.com>
Subject: Re: [PATCHv5 0/9] New EH command timeout handler
Date: Mon, 2 Sep 2013 02:31:29 -0700 [thread overview]
Message-ID: <20130902093129.GA17201@infradead.org> (raw)
In-Reply-To: <52245235.9020408@suse.de>
On Mon, Sep 02, 2013 at 10:54:13AM +0200, Hannes Reinecke wrote:
> I don't mind. Having talked to the various SCSI folks everyone
> agreed that calling abort asynchronously shouldn't do any harm.
> At least as far as the SCSI spec goes.
>
> As for documentation: I didn't document it it currently as with my
> implementation it's pretty much an optional thing.
> But if we were to enable it globally it surely should be documented.
>
> So if there is a consensus I surely can enable it globally and
> update the documentation.
I would defintively love enabling it globally. As a fallback we should
probably keep the old code for a while and prepare a way to disable
the async code by a flag in the host template. If no reason to enable
it shows up after a year ore two we can remove the old code entirely.
I.e change the tail of scsi_times_out into something like:
if (rtn == BLK_EH_NOT_HANDLED && !shost->hostt->no_async_abort) {
if (scsi_abort_command(scmd))
return BLK_EH_NOT_HANDLED;
}
scmd->result |= DID_TIME_OUT << 16;
...
That way we don't even need the new BLK_EH_SCHEDULED return value and
have all the handling in scsi_error.c
next prev parent reply other threads:[~2013-09-02 9:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 7:12 [PATCHv5 0/9] New EH command timeout handler Hannes Reinecke
2013-09-02 7:12 ` [PATCH 1/9] scsi: Fix erratic device offline during EH Hannes Reinecke
2013-09-02 7:12 ` [PATCH 2/9] blk-timeout: add BLK_EH_SCHEDULED return code Hannes Reinecke
2013-09-02 7:12 ` [PATCH 3/9] scsi: improved eh timeout handler Hannes Reinecke
2013-09-02 12:45 ` Bart Van Assche
2013-09-02 13:11 ` Hannes Reinecke
2013-09-02 16:38 ` Bart Van Assche
2013-09-03 9:13 ` Bart Van Assche
2013-09-04 7:02 ` Hannes Reinecke
2013-09-02 7:13 ` [PATCH 4/9] virtio_scsi: Enable new EH " Hannes Reinecke
2013-09-02 7:13 ` [PATCH 5/9] libsas: " Hannes Reinecke
2013-09-02 7:13 ` [PATCH 6/9] mptsas: " Hannes Reinecke
2013-09-02 7:13 ` [PATCH 7/9] mpt2sas: " Hannes Reinecke
2013-09-02 7:13 ` [PATCH 8/9] mpt3sas: " Hannes Reinecke
2013-09-02 7:13 ` [PATCH 9/9] scsi_transport_fc: " Hannes Reinecke
2013-09-02 8:27 ` [PATCHv5 0/9] New EH command " Christoph Hellwig
2013-09-02 8:54 ` Hannes Reinecke
2013-09-02 9:31 ` Christoph Hellwig [this message]
2013-09-02 9:59 ` Hannes Reinecke
2013-09-03 16:36 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130902093129.GA17201@infradead.org \
--to=hch@infradead.org \
--cc=bvanassche@acm.org \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=james.smart@emulex.com \
--cc=jbottomley@parallels.com \
--cc=joern@logfs.org \
--cc=linux-scsi@vger.kernel.org \
--cc=renmx@cn.fujitsu.com \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).