From: Dave Jones <davej@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: linux-scsi@vger.kernel.org, bgrove@attotech.com
Subject: Re: [SCSI] esas2r: ATTO Technology ExpressSAS 6G SAS/SATA RAID Adapter Driver
Date: Wed, 4 Sep 2013 19:27:25 -0400 [thread overview]
Message-ID: <20130904232725.GA5727@redhat.com> (raw)
In-Reply-To: <20130903233716.5333B660D6B@gitolite.kernel.org>
> +struct esas2r_adapter {
> + struct esas2r_target targetdb[ESAS2R_MAX_TARGETS];
> + struct esas2r_target *targetdb_end;
...
> + u8 fw_coredump_buff[ESAS2R_FWCOREDUMP_SZ];
> +void esas2r_reset_chip(struct esas2r_adapter *a)
> +{
> + if (!esas2r_is_adapter_present(a))
> + return;
> +
> + /*
> + * Before we reset the chip, save off the VDA core dump. The VDA core
> + * dump is located in the upper 512KB of the onchip SRAM. Make sure
> + * to not overwrite a previous crash that was saved.
> + */
> + if ((a->flags2 & AF2_COREDUMP_AVAIL)
> + && !(a->flags2 & AF2_COREDUMP_SAVED)
> + && a->fw_coredump_buff) {
> + esas2r_read_mem_block(a,
> + a->fw_coredump_buff,
> + MW_DATA_ADDR_SRAM + 0x80000,
> + ESAS2R_FWCOREDUMP_SZ);
Comparing an array (fw_coredump_buff) to null probably isn't what you intended here.
Dave
next parent reply other threads:[~2013-09-04 23:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130903233716.5333B660D6B@gitolite.kernel.org>
2013-09-04 23:27 ` Dave Jones [this message]
2020-04-10 14:09 [SCSI] esas2r: ATTO Technology ExpressSAS 6G SAS/SATA RAID Adapter Driver Colin Ian King
-- strict thread matches above, loose matches on Subject: below --
2014-09-18 14:23 Dan Carpenter
2013-08-29 8:46 Dan Carpenter
2013-08-29 8:45 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904232725.GA5727@redhat.com \
--to=davej@redhat.com \
--cc=bgrove@attotech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).