fix swapped arguments in aic7xxx:ahc_find_pci_device

fix swapped arguments in aic7xxx:ahc_find_pci_device

[Dave Jones]

The prototype for ahc_9005_subdevinfo_valid shows that the caller has the
arguments in the wrong order.

 637 ahc_9005_subdevinfo_valid(uint16_t device, uint16_t vendor,
 638                           uint16_t subdevice, uint16_t subvendor)

Signed-off-by: Dave Jones <davej@fedoraproject.org>

diff --git a/drivers/scsi/aic7xxx/aic7xxx_pci.c b/drivers/scsi/aic7xxx/aic7xxx_pci.c
index 6917b4f..22d5a94 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_pci.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_pci.c
@@ -692,7 +692,7 @@ ahc_find_pci_device(ahc_dev_softc_t pci)
 	 * ID as valid.
 	 */
 	if (ahc_get_pci_function(pci) > 0
-	 && ahc_9005_subdevinfo_valid(vendor, device, subvendor, subdevice)
+	 && ahc_9005_subdevinfo_valid(device, vendor, subdevice, subvendor)
 	 && SUBID_9005_MFUNCENB(subdevice) == 0)
 		return (NULL);
 

Re: fix swapped arguments in aic7xxx:ahc_find_pci_device

[Hannes Reinecke]

On 09/05/2013 04:33 AM, Dave Jones wrote:
> The prototype for ahc_9005_subdevinfo_valid shows that the caller has the
> arguments in the wrong order.
> 
>  637 ahc_9005_subdevinfo_valid(uint16_t device, uint16_t vendor,
>  638                           uint16_t subdevice, uint16_t subvendor)
> 
> Signed-off-by: Dave Jones <davej@fedoraproject.org>
Acked-by: Hannes Reinecke <hare@suse.de>

> 
> diff --git a/drivers/scsi/aic7xxx/aic7xxx_pci.c b/drivers/scsi/aic7xxx/aic7xxx_pci.c
> index 6917b4f..22d5a94 100644
> --- a/drivers/scsi/aic7xxx/aic7xxx_pci.c
> +++ b/drivers/scsi/aic7xxx/aic7xxx_pci.c
> @@ -692,7 +692,7 @@ ahc_find_pci_device(ahc_dev_softc_t pci)
>  	 * ID as valid.
>  	 */
>  	if (ahc_get_pci_function(pci) > 0
> -	 && ahc_9005_subdevinfo_valid(vendor, device, subvendor, subdevice)
> +	 && ahc_9005_subdevinfo_valid(device, vendor, subdevice, subvendor)
>  	 && SUBID_9005_MFUNCENB(subdevice) == 0)
>  		return (NULL);
>  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html