From: Jens Axboe <axboe@kernel.dk>
To: michaelc@cs.wisc.edu
Cc: linux-scsi@vger.kernel.org, JBottomley@parallels.com
Subject: Re: [PATCH] block: free bios when failing blk_execute_rq_nowait calls
Date: Wed, 18 Sep 2013 08:34:13 -0600 [thread overview]
Message-ID: <20130918143413.GC28478@kernel.dk> (raw)
In-Reply-To: <1379489869-4492-1-git-send-email-michaelc@cs.wisc.edu>
On Wed, Sep 18 2013, michaelc@cs.wisc.edu wrote:
> From: Mike Christie <michaelc@cs.wisc.edu>
>
> If the queue is dying then we only call the rq->end_io callout.
> This leaves bios setup on the request, because the caller assumes when
> the blk_execute_rq_nowait/blk_execute_rq call has completed that
> the rq->bios have been cleaned up.
>
> This patch has blk_execute_rq_nowait use __blk_end_request_all
> to free bios and also call rq->end_io.
Thanks Mike, applied.
--
Jens Axboe
prev parent reply other threads:[~2013-09-18 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 7:37 [PATCH] block: free bios when failing blk_execute_rq_nowait calls michaelc
2013-09-18 14:34 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130918143413.GC28478@kernel.dk \
--to=axboe@kernel.dk \
--cc=JBottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).