From: Christoph Hellwig <hch@infradead.org>
To: Andy Grover <agrover@redhat.com>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com
Subject: Re: [PATCH] target: Pass through I/O topology for block backstores
Date: Fri, 11 Oct 2013 11:03:48 -0700 [thread overview]
Message-ID: <20131011180348.GA21030@infradead.org> (raw)
In-Reply-To: <1381513206-8155-1-git-send-email-agrover@redhat.com>
On Fri, Oct 11, 2013 at 10:40:06AM -0700, Andy Grover wrote:
> In addition to block size (already implemented), passing through
> alignment offset, logical-to-phys block exponent, I/O granularity and
> optimal I/O length will allow initiators to properly handle layout on
> LUNs with 4K block sizes.
>
> Tested with various weird values via scsi_debug module.
>
> One thing to look at with this patch is the new block limits values --
> instead of granularity 1 optimal 8192, Lio will now be returning whatever
> the block device says, which may affect performance.
Wouldn't it be nicer to have a single method that takes a whole
queue_limits structure?
next prev parent reply other threads:[~2013-10-11 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 17:40 [PATCH] target: Pass through I/O topology for block backstores Andy Grover
2013-10-11 18:03 ` Christoph Hellwig [this message]
2013-10-11 18:52 ` Andy Grover
2013-10-12 8:08 ` Christoph Hellwig
2013-10-16 22:29 ` Andy Grover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011180348.GA21030@infradead.org \
--to=hch@infradead.org \
--cc=agrover@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).