From: Christoph Hellwig <hch@infradead.org>
To: Andy Grover <agrover@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com
Subject: Re: [PATCH] target: Pass through I/O topology for block backstores
Date: Sat, 12 Oct 2013 01:08:24 -0700 [thread overview]
Message-ID: <20131012080824.GA12362@infradead.org> (raw)
In-Reply-To: <52584905.4080307@redhat.com>
On Fri, Oct 11, 2013 at 11:52:53AM -0700, Andy Grover wrote:
> It seemed better to me to keep the munging from queue_limits values
> to what the target core needed in the block backstore code, and not
> use a block-specific structure in the backstore<->core interface.
>
> It looks like a few includes of blkdev.h slipped into target core,
> but these can be removed safely -- lio core doesn't depend on the
> block layer.
>
> We could define a new struct to get the 4 values at once, but it
> didn't seem worth it, esp. since two are only needed by
> emulate_readcapacity16, and the other two only by emulate_evpd_b0.
I really don't like the influx of methods. But given thsat you have
done the work I'd say merge your patch for now and then we can later see
if we can come up with something more elegant.
next prev parent reply other threads:[~2013-10-12 8:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 17:40 [PATCH] target: Pass through I/O topology for block backstores Andy Grover
2013-10-11 18:03 ` Christoph Hellwig
2013-10-11 18:52 ` Andy Grover
2013-10-12 8:08 ` Christoph Hellwig [this message]
2013-10-16 22:29 ` Andy Grover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131012080824.GA12362@infradead.org \
--to=hch@infradead.org \
--cc=agrover@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).