* self assignment bug in aix94xx
@ 2013-10-24 8:55 Dave Jones
2013-10-24 9:03 ` James Bottomley
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2013-10-24 8:55 UTC (permalink / raw)
To: linux-scsi
2908d778 (James Bottomley 2006-08-29 09:22:51 -0500 515) scb->ssp_task.retry_count = scb->ssp_task.retry_count;
Is this supposed to maybe be..
scb->ssp_task.retry_count = task->ssp_task.retry_count;
?
(This and a whole bunch of similar bugs found with Coverity.)
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: self assignment bug in aix94xx
2013-10-24 8:55 self assignment bug in aix94xx Dave Jones
@ 2013-10-24 9:03 ` James Bottomley
0 siblings, 0 replies; 2+ messages in thread
From: James Bottomley @ 2013-10-24 9:03 UTC (permalink / raw)
To: Dave Jones; +Cc: linux-scsi
On Thu, 2013-10-24 at 04:55 -0400, Dave Jones wrote:
> 2908d778 (James Bottomley 2006-08-29 09:22:51 -0500 515) scb->ssp_task.retry_count = scb->ssp_task.retry_count;
>
> Is this supposed to maybe be..
>
> scb->ssp_task.retry_count = task->ssp_task.retry_count;
>
> ?
Oh, boy, this was the master commit for aic94xx (so it's not me it was a
bunch of people working on the driver). I'll see if I can analyse the
logic flow to find out what should have been going on, but it will take
a couple of weeks.
> (This and a whole bunch of similar bugs found with Coverity.)
May as well send them along and I'll look at them too.
James
> Dave
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-24 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-24 8:55 self assignment bug in aix94xx Dave Jones
2013-10-24 9:03 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox