From: Dave Jones <davej@redhat.com>
To: jayamohank@serverengines.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: strange comparison in be2iscsi
Date: Thu, 24 Oct 2013 05:42:44 -0400 [thread overview]
Message-ID: <20131024094244.GB19018@redhat.com> (raw)
In-Reply-To: <20131024084721.GA15720@redhat.com>
On Thu, Oct 24, 2013 at 04:47:21AM -0400, Dave Jones wrote:
> A few years ago, in 4183122dbc7c489f11971c5afa8e42011bca7fa2
> this code was added to drivers/scsi/be2iscsi/be_main.c
>
> + if (abrt_task->sc->device->lun != abrt_task->sc->device->lun)
> + continue;
>
> Which doesn't make a lot of sense.
> What was the intent here ?
Also elsewhere we have this..
6733b39a (Jayamohan Kallickal 2009-09-05 07:36:35 +0530 1583) phys_addr.u.a64.address =
6733b39a (Jayamohan Kallickal 2009-09-05 07:36:35 +0530 1584) *((unsigned long long *)(&phys_addr.u.a64.address));
which looks like a pretty convoluted way to assign a var to itself.
Dave
prev parent reply other threads:[~2013-10-24 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 8:47 strange comparison in be2iscsi Dave Jones
2013-10-24 9:42 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024094244.GB19018@redhat.com \
--to=davej@redhat.com \
--cc=jayamohank@serverengines.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox