* strange comparison in be2iscsi
@ 2013-10-24 8:47 Dave Jones
2013-10-24 9:42 ` Dave Jones
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2013-10-24 8:47 UTC (permalink / raw)
To: jayamohank; +Cc: linux-scsi
A few years ago, in 4183122dbc7c489f11971c5afa8e42011bca7fa2
this code was added to drivers/scsi/be2iscsi/be_main.c
+ if (abrt_task->sc->device->lun != abrt_task->sc->device->lun)
+ continue;
Which doesn't make a lot of sense.
What was the intent here ?
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: strange comparison in be2iscsi
2013-10-24 8:47 strange comparison in be2iscsi Dave Jones
@ 2013-10-24 9:42 ` Dave Jones
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jones @ 2013-10-24 9:42 UTC (permalink / raw)
To: jayamohank; +Cc: linux-scsi
On Thu, Oct 24, 2013 at 04:47:21AM -0400, Dave Jones wrote:
> A few years ago, in 4183122dbc7c489f11971c5afa8e42011bca7fa2
> this code was added to drivers/scsi/be2iscsi/be_main.c
>
> + if (abrt_task->sc->device->lun != abrt_task->sc->device->lun)
> + continue;
>
> Which doesn't make a lot of sense.
> What was the intent here ?
Also elsewhere we have this..
6733b39a (Jayamohan Kallickal 2009-09-05 07:36:35 +0530 1583) phys_addr.u.a64.address =
6733b39a (Jayamohan Kallickal 2009-09-05 07:36:35 +0530 1584) *((unsigned long long *)(&phys_addr.u.a64.address));
which looks like a pretty convoluted way to assign a var to itself.
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-24 9:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-24 8:47 strange comparison in be2iscsi Dave Jones
2013-10-24 9:42 ` Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox