From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com>
Cc: JBottomley@Parallels.com, linux-scsi@vger.kernel.org,
torvalds@linux-foundation.org, aacraid@adaptec.com,
aacraid@pmc-sierra.com, Achim.Leubner@pmcs.com,
Tony.Ruiz@pmcs.com
Subject: Re: [PATCH 1/1] aacraid: prevent ZERO_SIZE_PTR dereference
Date: Thu, 31 Oct 2013 12:44:58 +0300 [thread overview]
Message-ID: <20131031094458.GL20521@mwanda> (raw)
In-Reply-To: <1383208262-3203-1-git-send-email-Mahesh.Rajashekhara@pmcs.com>
On Thu, Oct 31, 2013 at 02:01:02PM +0530, Mahesh Rajashekhara wrote:
> It appears that driver runs into a problem here if fibsize is too small because we allocate user_srbcmd with fibsize size only but later we access it until user_srbcmd->sg.count to copy it over to srbcmd. Seems to be not correct to test (fibsize < sizeof(*user_srbcmd)) because this structure already includes one sg element and this is not needed for commands without data. So, we would recommend to add the following (instead of test for fibsize == 0).
>
Don't forget the reported by tags.
Reported-by: Nico Golde <nico@ngolde.de>
Reported-by: Fabian Yamaguchi <fabs@goesec.de>
regards,
dan carpenter
prev parent reply other threads:[~2013-10-31 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 8:31 [PATCH 1/1] aacraid: prevent ZERO_SIZE_PTR dereference Mahesh Rajashekhara
2013-10-31 9:44 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031094458.GL20521@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Achim.Leubner@pmcs.com \
--cc=JBottomley@Parallels.com \
--cc=Mahesh.Rajashekhara@pmcs.com \
--cc=Tony.Ruiz@pmcs.com \
--cc=aacraid@adaptec.com \
--cc=aacraid@pmc-sierra.com \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).