From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <jbottomley@parallels.com>,
Christoph Hellwig <hch@infradead.org>,
linux-scsi@vger.kernel.org, Ren Mingxin <renmx@cn.fujitsu.com>,
Joern Engel <joern@logfs.org>,
James Smart <james.smart@emulex.com>
Subject: Re: [PATCH 2/3] scsi: improved eh timeout handler
Date: Thu, 31 Oct 2013 08:49:05 -0700 [thread overview]
Message-ID: <20131031154905.GA10451@infradead.org> (raw)
In-Reply-To: <1383224573-113346-3-git-send-email-hare@suse.de>
Looks reasonable to me, but a few minor nitpicks:
> + spin_lock_irqsave(sdev->host->host_lock, flags);
> + if (scsi_host_eh_past_deadline(sdev->host)) {
I don't have the implementation of scsi_host_eh_past_deadline in my
local tree, but do we really need the host lock for it?
> +int
> +scsi_abort_command(struct scsi_cmnd *scmd)
Semms like this should be static and not exported in the current version
of the code?
next prev parent reply other threads:[~2013-10-31 15:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 13:02 [PATCHv8 0/3] New EH command timeout handler Hannes Reinecke
2013-10-31 13:02 ` [PATCH 1/3] scsi: Fix erratic device offline during EH Hannes Reinecke
2013-10-31 13:02 ` [PATCH 2/3] scsi: improved eh timeout handler Hannes Reinecke
2013-10-31 15:49 ` Christoph Hellwig [this message]
2013-11-04 13:36 ` Hannes Reinecke
2013-11-04 14:25 ` James Bottomley
2013-11-04 14:46 ` Hannes Reinecke
2013-11-04 14:50 ` James Bottomley
2013-11-04 15:43 ` Hannes Reinecke
2013-11-05 1:07 ` James Bottomley
2013-11-01 6:10 ` Ren Mingxin
2013-10-31 13:02 ` [PATCH 3/3] scsi: Update documentation Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2013-09-02 11:58 [PATCHv6 0/3] New EH command timeout handler Hannes Reinecke
2013-09-02 11:58 ` [PATCH 2/3] scsi: improved eh " Hannes Reinecke
2013-09-11 9:16 ` Ren Mingxin
2013-09-12 20:49 ` Hannes Reinecke
2013-09-20 7:59 ` Ren Mingxin
2013-10-02 16:24 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031154905.GA10451@infradead.org \
--to=hch@infradead.org \
--cc=hare@suse.de \
--cc=james.smart@emulex.com \
--cc=jbottomley@parallels.com \
--cc=joern@logfs.org \
--cc=linux-scsi@vger.kernel.org \
--cc=renmx@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).