linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 3/6] scsi-mq: Don't set QUEUE_FLAG_NONROT in scsi_mq_alloc_queue().
@ 2013-11-29  8:42 majianpeng
  2013-12-23  6:33 ` Nicholas A. Bellinger
  0 siblings, 1 reply; 2+ messages in thread
From: majianpeng @ 2013-11-29  8:42 UTC (permalink / raw)
  To: nab; +Cc: linux-scsi

This flag will be set in sd_revalidate_disk().So remove this operation.

Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
---
 drivers/scsi/scsi-mq.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/scsi-mq.c b/drivers/scsi/scsi-mq.c
index eccdbd5..933ba0f 100644
--- a/drivers/scsi/scsi-mq.c
+++ b/drivers/scsi/scsi-mq.c
@@ -206,8 +206,6 @@ int scsi_mq_alloc_queue(struct Scsi_Host *sh, struct scsi_device *sdev)
 			}
 		}
 	}
-//FIXME: Check for !NONROT usage
-	queue_flag_set_unlocked(QUEUE_FLAG_NONROT, q);
 
 	printk("scsi_mq_alloc_queue() complete !! >>>>>>>>>>>>>>>>>>>>>>>>>>>\n");
 	return 0;
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/6] scsi-mq: Don't set QUEUE_FLAG_NONROT in scsi_mq_alloc_queue().
  2013-11-29  8:42 [PATCH 3/6] scsi-mq: Don't set QUEUE_FLAG_NONROT in scsi_mq_alloc_queue() majianpeng
@ 2013-12-23  6:33 ` Nicholas A. Bellinger
  0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2013-12-23  6:33 UTC (permalink / raw)
  To: majianpeng; +Cc: linux-scsi

On Fri, 2013-11-29 at 16:42 +0800, majianpeng wrote:
> This flag will be set in sd_revalidate_disk().So remove this operation.
> 
> Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
> ---
>  drivers/scsi/scsi-mq.c |    2 --
>  1 file changed, 2 deletions(-)
> 

Applied, + squashed into current target-pending/scsi-mq code.

Thanks Jianpeng!

--nab

> diff --git a/drivers/scsi/scsi-mq.c b/drivers/scsi/scsi-mq.c
> index eccdbd5..933ba0f 100644
> --- a/drivers/scsi/scsi-mq.c
> +++ b/drivers/scsi/scsi-mq.c
> @@ -206,8 +206,6 @@ int scsi_mq_alloc_queue(struct Scsi_Host *sh, struct scsi_device *sdev)
>  			}
>  		}
>  	}
> -//FIXME: Check for !NONROT usage
> -	queue_flag_set_unlocked(QUEUE_FLAG_NONROT, q);
>  
>  	printk("scsi_mq_alloc_queue() complete !! >>>>>>>>>>>>>>>>>>>>>>>>>>>\n");
>  	return 0;



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-12-23  6:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-29  8:42 [PATCH 3/6] scsi-mq: Don't set QUEUE_FLAG_NONROT in scsi_mq_alloc_queue() majianpeng
2013-12-23  6:33 ` Nicholas A. Bellinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).