From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Nagalakshmi Nandigama <Nagalakshmi.Nandigama@lsi.com>,
Sreekanth Reddy <Sreekanth.Reddy@lsi.com>,
support@lsi.com, DL-MPTFusionLinux@lsi.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/3] drivers: message: Mark function mpt_SoftResetHandler() as static in mptbase.c
Date: Fri, 13 Dec 2013 00:59:50 -0800 [thread overview]
Message-ID: <20131213085950.GH4386@leaf> (raw)
In-Reply-To: <0a6b017550306ed600769dbe4fac868aa88cd9d6.1386914148.git.rashika.kheria@gmail.com>
On Fri, Dec 13, 2013 at 11:33:11AM +0530, Rashika Kheria wrote:
> This patch marks the function mpt_SoftResetHandler() as static in mptbase.c
> because it is not used outside this file.
>
> Thus, it also eliminates the following warning in fusion/mptbase.c:
> drivers/message/fusion/mptbase.c:7011:1: warning: no previous prototype for ‘mpt_SoftResetHandler’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/message/fusion/mptbase.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
> index 767ff4d..c783a42 100644
> --- a/drivers/message/fusion/mptbase.c
> +++ b/drivers/message/fusion/mptbase.c
> @@ -7007,7 +7007,7 @@ EXPORT_SYMBOL(mpt_halt_firmware);
> * IOC doesn't reply to any outstanding request. This will transfer IOC
> * to READY state.
> **/
> -int
> +static int
> mpt_SoftResetHandler(MPT_ADAPTER *ioc, int sleepFlag)
> {
> int rc;
> --
> 1.7.9.5
>
prev parent reply other threads:[~2013-12-13 8:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 6:03 [PATCH 1/3] drivers: message: Mark function mpt_SoftResetHandler() as static in mptbase.c Rashika Kheria
2013-12-13 6:06 ` [PATCH 2/3] drivers: message: Mark function mptscsih_quiesce_raid() as static in mptspi.c Rashika Kheria
2013-12-13 9:00 ` Josh Triplett
2013-12-13 6:10 ` [PATCH 3/3] drivers: message: Mark functions as static in mptsas.c Rashika Kheria
2013-12-13 9:01 ` Josh Triplett
2013-12-13 8:59 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213085950.GH4386@leaf \
--to=josh@joshtriplett.org \
--cc=DL-MPTFusionLinux@lsi.com \
--cc=Nagalakshmi.Nandigama@lsi.com \
--cc=Sreekanth.Reddy@lsi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=support@lsi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).