From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Nagalakshmi Nandigama <Nagalakshmi.Nandigama@lsi.com>,
Sreekanth Reddy <Sreekanth.Reddy@lsi.com>,
support@lsi.com, DL-MPTFusionLinux@lsi.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/3] drivers: message: Mark functions as static in mptsas.c
Date: Fri, 13 Dec 2013 01:01:30 -0800 [thread overview]
Message-ID: <20131213090130.GJ4386@leaf> (raw)
In-Reply-To: <14b2696b781c98ce10a0075753bbe2cc7c7fc2e7.1386914148.git.rashika.kheria@gmail.com>
On Fri, Dec 13, 2013 at 11:40:35AM +0530, Rashika Kheria wrote:
> This patch marks the function mptsas_refreshing_device_handles(),
> mptsas_expander_add() and mptsas_shutdown() as static in fusion/mptsas.c
> because they are not used outside this file.
>
> Thus, it also eliminates the following warnings in fusion/mptsas.c:
> drivers/message/fusion/mptsas.c:1579:1: warning: no previous prototype for ‘mptsas_refreshing_device_handles’ [-Wmissing-prototypes]
> drivers/message/fusion/mptsas.c:3654:1: warning: no previous prototype for ‘mptsas_expander_add’ [-Wmissing-prototypes]
> drivers/message/fusion/mptsas.c:5327:1: warning: no previous prototype for ‘mptsas_shutdown’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/message/fusion/mptsas.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c
> index dd239bd..906f448 100644
> --- a/drivers/message/fusion/mptsas.c
> +++ b/drivers/message/fusion/mptsas.c
> @@ -1575,7 +1575,7 @@ mptsas_del_end_device(MPT_ADAPTER *ioc, struct mptsas_phyinfo *phy_info)
> mptsas_port_delete(ioc, phy_info->port_details);
> }
>
> -struct mptsas_phyinfo *
> +static struct mptsas_phyinfo *
> mptsas_refreshing_device_handles(MPT_ADAPTER *ioc,
> struct mptsas_devinfo *sas_device)
> {
> @@ -3650,7 +3650,7 @@ mptsas_send_expander_event(struct fw_event_work *fw_event)
> * @handle:
> *
> */
> -struct mptsas_portinfo *
> +static struct mptsas_portinfo *
> mptsas_expander_add(MPT_ADAPTER *ioc, u16 handle)
> {
> struct mptsas_portinfo buffer, *port_info;
> @@ -5323,7 +5323,7 @@ mptsas_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> return error;
> }
>
> -void
> +static void
> mptsas_shutdown(struct pci_dev *pdev)
> {
> MPT_ADAPTER *ioc = pci_get_drvdata(pdev);
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2013-12-13 9:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 6:03 [PATCH 1/3] drivers: message: Mark function mpt_SoftResetHandler() as static in mptbase.c Rashika Kheria
2013-12-13 6:06 ` [PATCH 2/3] drivers: message: Mark function mptscsih_quiesce_raid() as static in mptspi.c Rashika Kheria
2013-12-13 9:00 ` Josh Triplett
2013-12-13 6:10 ` [PATCH 3/3] drivers: message: Mark functions as static in mptsas.c Rashika Kheria
2013-12-13 9:01 ` Josh Triplett [this message]
2013-12-13 8:59 ` [PATCH 1/3] drivers: message: Mark function mpt_SoftResetHandler() as static in mptbase.c Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213090130.GJ4386@leaf \
--to=josh@joshtriplett.org \
--cc=DL-MPTFusionLinux@lsi.com \
--cc=Nagalakshmi.Nandigama@lsi.com \
--cc=Sreekanth.Reddy@lsi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=support@lsi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).