From mboxrd@z Thu Jan 1 00:00:00 1970 From: josh@joshtriplett.org Subject: Re: [PATCH 2/4] drivers: target: Mark function as static in target_core_iblock.c Date: Wed, 18 Dec 2013 10:38:46 -0800 Message-ID: <20131218183846.GB24229@cloud> References: <1a63603bc5ff05147c419a301d59b135cd0c8406.1387390091.git.rashika.kheria@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: target-devel-owner@vger.kernel.org To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, "Nicholas A. Bellinger" , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On Wed, Dec 18, 2013 at 11:56:44PM +0530, Rashika Kheria wrote: > Mark function iblock_get_write_cache() as static in target_core_ibloc= k.c > because it is not used outside this file. >=20 > This eliminates the following warning in target_core_iblock.c: > drivers/target/target_core_iblock.c:766:6: warning: no previous proto= type for =E2=80=98iblock_get_write_cache=E2=80=99 [-Wmissing-prototypes= ] >=20 > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/target/target_core_iblock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/target/target_core_iblock.c b/drivers/target/tar= get_core_iblock.c > index c87959f..15d9121 100644 > --- a/drivers/target/target_core_iblock.c > +++ b/drivers/target/target_core_iblock.c > @@ -763,7 +763,7 @@ iblock_parse_cdb(struct se_cmd *cmd) > return sbc_parse_cdb(cmd, &iblock_sbc_ops); > } > =20 > -bool iblock_get_write_cache(struct se_device *dev) > +static bool iblock_get_write_cache(struct se_device *dev) > { > struct iblock_dev *ib_dev =3D IBLOCK_DEV(dev); > struct block_device *bd =3D ib_dev->ibd_bd; > --=20 > 1.7.9.5 >=20