public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Brian King <brking@linux.vnet.ibm.com>,
	Robert Jennings <rcj@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] ibmvscsi: Speed up kexec boot
Date: Mon, 23 Dec 2013 18:28:16 +1100	[thread overview]
Message-ID: <20131223182816.0e8985af@kryten> (raw)


During kexec boot we call ibmvscsi_release_crq_queue() to tear down
the old CRQ from the previous kernel. ibmvscsi_release_crq_queue()
does this by calling H_FREE_CRQ. The hypervisor breaks this work
down so as limit the time spent in any one hcall, so we have to loop
until complete.

At the moment we delay 0.1 seconds between every H_FREE_CRQ call.
I see us calling H_FREE_CRQ 60 times on my box which means we
delayed a total of 6 seconds.

This delay is overkill, we are free to handle all busy return codes
from the hypervisor as we see fit. Cut the delay down to something
more reasonable - 1 ms. This improves my boot time by 6 seconds.

Fix the other places we have arbitrary 100 ms delays.

Signed-off-by: Anton Blanchard <anton@samba.org>
---

diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index fa76440..ed7b52e 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -159,7 +159,7 @@ static void ibmvscsi_release_crq_queue(struct crq_queue *queue,
 	tasklet_kill(&hostdata->srp_task);
 	do {
 		if (rc)
-			msleep(100);
+			msleep(1);
 		rc = plpar_hcall_norets(H_FREE_CRQ, vdev->unit_address);
 	} while ((rc == H_BUSY) || (H_IS_LONG_BUSY(rc)));
 	dma_unmap_single(hostdata->dev,
@@ -292,7 +292,7 @@ static int ibmvscsi_reset_crq_queue(struct crq_queue *queue,
 	/* Close the CRQ */
 	do {
 		if (rc)
-			msleep(100);
+			msleep(1);
 		rc = plpar_hcall_norets(H_FREE_CRQ, vdev->unit_address);
 	} while ((rc == H_BUSY) || (H_IS_LONG_BUSY(rc)));
 
@@ -392,7 +392,7 @@ static int ibmvscsi_init_crq_queue(struct crq_queue *queue,
 	rc = 0;
 	do {
 		if (rc)
-			msleep(100);
+			msleep(1);
 		rc = plpar_hcall_norets(H_FREE_CRQ, vdev->unit_address);
 	} while ((rc == H_BUSY) || (H_IS_LONG_BUSY(rc)));
       reg_crq_failed:
@@ -420,7 +420,7 @@ static int ibmvscsi_reenable_crq_queue(struct crq_queue *queue,
 	/* Re-enable the CRQ */
 	do {
 		if (rc)
-			msleep(100);
+			msleep(1);
 		rc = plpar_hcall_norets(H_ENABLE_CRQ, vdev->unit_address);
 	} while ((rc == H_IN_PROGRESS) || (rc == H_BUSY) || (H_IS_LONG_BUSY(rc)));
 

             reply	other threads:[~2013-12-23  7:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-23  7:28 Anton Blanchard [this message]
2014-03-28  5:49 ` [PATCH] ibmvscsi: Speed up kexec boot Anton Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131223182816.0e8985af@kryten \
    --to=anton@samba.org \
    --cc=brking@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rcj@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox