From: Christoph Hellwig <hch@infradead.org>
To: Muthu Kumar <muthu.lkml@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
James Bottomley <JBottomley@parallels.com>,
Nicholas Bellinger <nab@linux-iscsi.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 01/15] block: rework flush sequencing for blk-mq
Date: Thu, 6 Feb 2014 08:18:16 -0800 [thread overview]
Message-ID: <20140206161816.GC16916@infradead.org> (raw)
In-Reply-To: <CAFR8ueegsgqiTruZkGxeSL4KCyxYzZUzqvWw42ZLiOZgUapH8w@mail.gmail.com>
On Wed, Feb 05, 2014 at 06:08:37PM -0800, Muthu Kumar wrote:
> > diff --git a/block/blk-core.c b/block/blk-core.c
> > index c00e0bd..d3eb330 100644
> > --- a/block/blk-core.c
> > +++ b/block/blk-core.c
> > @@ -693,11 +693,20 @@ blk_init_queue_node(request_fn_proc *rfn, spinlock_t *lock, int node_id)
> > if (!uninit_q)
> > return NULL;
> >
> > + uninit_q->flush_rq = kzalloc(sizeof(struct request), GFP_KERNEL);
>
>
> Shouldn't this be kzalloc_node()?
Probably. There's also various kinds of optimization potential like
allocating one per hw_ctx or similar. But until we have a device that
has high enough IOPS to matter and needs cache flushes I wouldn't worry
about optimizing the flush path.
next prev parent reply other threads:[~2014-02-06 16:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 12:41 [PATCH 00/15] A different approach for using blk-mq in the SCSI layer Christoph Hellwig
2014-02-05 12:41 ` [PATCH 01/15] block: rework flush sequencing for blk-mq Christoph Hellwig
2014-02-06 2:08 ` Muthu Kumar
2014-02-06 16:18 ` Christoph Hellwig [this message]
2014-02-05 12:41 ` [PATCH 02/15] blk-mq: support at_head inserations for blk_execute_rq Christoph Hellwig
2014-02-06 2:27 ` Muthu Kumar
2014-02-06 16:17 ` Christoph Hellwig
2014-02-06 17:05 ` Muthu Kumar
2014-02-06 17:10 ` Christoph Hellwig
2014-02-05 12:41 ` [PATCH 03/15] blk-mq: divert __blk_put_request for MQ ops Christoph Hellwig
2014-02-05 12:41 ` [PATCH 04/15] blk-mq: handle dma_drain_size Christoph Hellwig
2014-02-05 12:41 ` [PATCH 05/15] blk-mq: initialize sg_reserved_size Christoph Hellwig
2014-02-05 12:41 ` [PATCH 06/15] scsi: reintroduce scsi_driver.init_command Christoph Hellwig
2014-02-05 12:41 ` [PATCH 07/15] block: remove unprep_rq_fn Christoph Hellwig
2014-02-05 12:41 ` [PATCH 08/15] scsi: cleanup scsi_end_request calling conventions Christoph Hellwig
2014-02-05 12:41 ` [PATCH 09/15] scsi: centralize command re-queueing in scsi_dispatch_fn Christoph Hellwig
2014-02-05 12:41 ` [PATCH 10/15] scsi: split __scsi_queue_insert Christoph Hellwig
2014-02-05 12:41 ` [PATCH 11/15] scsi: factor out __scsi_init_queue Christoph Hellwig
2014-02-05 12:41 ` [PATCH 12/15] scsi: initial blk-mq support Christoph Hellwig
2014-02-06 8:38 ` Sagi Grimberg
2014-02-06 16:16 ` Christoph Hellwig
2014-02-06 22:11 ` Nicholas A. Bellinger
2014-02-07 8:45 ` Mike Christie
2014-02-07 12:42 ` Christoph Hellwig
2014-02-07 12:51 ` Christoph Hellwig
2014-02-05 12:41 ` [PATCH 13/15] scsi: partially stub out scsi_adjust_queue_depth when using blk-mq Christoph Hellwig
2014-02-05 12:41 ` [PATCH 14/15] iscsi_tcp: use blk_mq Christoph Hellwig
2014-02-05 12:41 ` [PATCH 15/15] virtio_scsi: " Christoph Hellwig
2014-02-10 11:35 ` [PATCH 00/15] A different approach for using blk-mq in the SCSI layer Christoph Hellwig
2014-02-10 19:38 ` Nicholas A. Bellinger
2014-02-24 14:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140206161816.GC16916@infradead.org \
--to=hch@infradead.org \
--cc=JBottomley@parallels.com \
--cc=axboe@kernel.dk \
--cc=linux-scsi@vger.kernel.org \
--cc=muthu.lkml@gmail.com \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox