Re: [patch] [SCSI] arcmsr: upper 32 of dma address lost

[Dan Carpenter <dan.carpenter@oracle.com>]

On Fri, Feb 07, 2014 at 04:00:28PM +0300, Dan Carpenter wrote:
> The original code always set the upper 32 bits to zero because it was
> doing a shift of the wrong variable.
> 

Actually let me redo this.  I want to add a cast to prevent a static
checker warning on 32 bit systems.  Sorry, for the noise.

regards,
dan carpenter

> Fixes: 1a4f550a09f8 ('[SCSI] arcmsr: 1.20.00.15: add SATA RAID plus other fixes')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
> index 4f6a30b8e5f9..9cfd399c47c0 100644
> --- a/drivers/scsi/arcmsr/arcmsr_hba.c
> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
> @@ -2500,16 +2500,15 @@ static int arcmsr_polling_ccbdone(struct AdapterControlBlock *acb,
>  static int arcmsr_iop_confirm(struct AdapterControlBlock *acb)
>  {
>  	uint32_t cdb_phyaddr, cdb_phyaddr_hi32;
> -	dma_addr_t dma_coherent_handle;
> +
>  	/*
>  	********************************************************************
>  	** here we need to tell iop 331 our freeccb.HighPart
>  	** if freeccb.HighPart is not zero
>  	********************************************************************
>  	*/
> -	dma_coherent_handle = acb->dma_coherent_handle;
> -	cdb_phyaddr = (uint32_t)(dma_coherent_handle);
> -	cdb_phyaddr_hi32 = (uint32_t)((cdb_phyaddr >> 16) >> 16);
> +	cdb_phyaddr = (uint32_t)(acb->dma_coherent_handle);
> +	cdb_phyaddr_hi32 = (uint32_t)(acb->dma_coherent_handle >> 32);
>  	acb->cdb_phyaddr_hi32 = cdb_phyaddr_hi32;
>  	/*
>  	***********************************************************************