From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
James Bottomley <jbottomley@parallels.com>,
linux-scsi@vger.kernel.org, Christoph Hellwig <hch@infradead.com>,
Ren Mingxin <renmx@cn.fujitsu.com>, Joern Engel <joern@logfs.org>,
James Smart <james.smart@emulex.com>
Subject: Re: [PATCH 2/5] scsi: improved eh timeout handler
Date: Tue, 11 Feb 2014 23:45:24 -0800 [thread overview]
Message-ID: <20140212074524.GA4529@infradead.org> (raw)
In-Reply-To: <52FA33B6.9010501@suse.de>
On Tue, Feb 11, 2014 at 03:29:10PM +0100, Hannes Reinecke wrote:
> Well, _actually_ the cancel_delayed_work should be pointless; I've
> just added it as a terminal measure here.
> (It'd actually be an idea to insert a BUG_ON() here ...)
>
> Thing is whenever the eh_timeout thingie kicks in we most definitely
> know there's a command in flight, and hence scsi_command_put()
> should _never_ be called.
> Only after eh_abort has finished the command will be returned via
> scsi_command_put(), but then eh_abort is done for, too, and no item
> should remain in the workqueue.
The issue I saw actually was with a different workqueue, sorry for the
noise. I have to say I really hate the generic workqueue workers which
make it almost impossible to debug issues before they hit the actual
worker function..
next prev parent reply other threads:[~2014-02-12 7:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 12:44 [PATCHv11 0/5] New EH command timeout handler Hannes Reinecke
2013-11-11 12:44 ` [PATCH 1/5] scsi: Fix erratic device offline during EH Hannes Reinecke
2013-11-11 12:44 ` [PATCH 2/5] scsi: improved eh timeout handler Hannes Reinecke
2014-02-11 14:01 ` Christoph Hellwig
2014-02-11 14:29 ` Hannes Reinecke
2014-02-12 7:45 ` Christoph Hellwig [this message]
2014-02-12 7:49 ` Hannes Reinecke
2013-11-11 12:44 ` [PATCH 3/5] scsi: Unlock accesses to eh_deadline Hannes Reinecke
2013-11-11 12:44 ` [PATCH 4/5] scsi: Set the minimum valid value of 'eh_deadline' as 0 Hannes Reinecke
2013-11-11 12:44 ` [PATCH 5/5] scsi: Update documentation Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2013-11-05 7:05 [PATCHv10 0/5] New EH command timeout handler Hannes Reinecke
2013-11-05 7:05 ` [PATCH 2/5] scsi: improved eh " Hannes Reinecke
2013-11-05 19:19 ` Mike Christie
2013-11-06 6:48 ` Hannes Reinecke
2013-11-06 17:23 ` Mike Christie
2013-11-07 6:45 ` Hannes Reinecke
2013-11-07 18:33 ` Douglas Gilbert
2013-11-08 15:54 ` Hannes Reinecke
2013-11-09 8:35 ` James Bottomley
2013-11-09 15:27 ` Hannes Reinecke
2013-11-06 14:47 ` Christoph Hellwig
2013-11-07 6:42 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212074524.GA4529@infradead.org \
--to=hch@infradead.org \
--cc=hare@suse.de \
--cc=hch@infradead.com \
--cc=james.smart@emulex.com \
--cc=jbottomley@parallels.com \
--cc=joern@logfs.org \
--cc=linux-scsi@vger.kernel.org \
--cc=renmx@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).