From: Jens Axboe <axboe@kernel.dk>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Akinobu Mita <akinobu.mita@gmail.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagig@mellanox.com>,
kmo@daterainc.com
Subject: Re: loading scsi_debug with data integrity hits BUG_ON
Date: Fri, 21 Feb 2014 15:56:48 -0800 [thread overview]
Message-ID: <20140221235648.GG29129@kernel.dk> (raw)
In-Reply-To: <1392924492.29525.22.camel@haakon3.risingtidesystems.com>
On Thu, Feb 20 2014, Nicholas A. Bellinger wrote:
> On Thu, 2014-02-20 at 14:16 -0500, Martin K. Petersen wrote:
> > >>>>> "nab" == Nicholas A Bellinger <nab@linux-iscsi.org> writes:
> >
> > nab> Given that there is no (easy) way to ascertain what the original
> > nab> value of bio_integrity->bip_iter.bi_size was post
> > nab> bio_integrity_advance(), dropping this BUG_ON() probably makes the
> > nab> most sense.
> >
> > nab> MKP + Jens, care to ACK + pickup..?
> >
> > Please remove total as suggested by Akinobu.
> >
> > Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
> >
>
> Thanks. Here's an updated patch for Jen's to pickup.
Got it, thanks!
--
Jens Axboe
next prev parent reply other threads:[~2014-02-21 23:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 13:22 loading scsi_debug with data integrity hits BUG_ON Akinobu Mita
2014-02-20 1:10 ` Nicholas A. Bellinger
2014-02-20 13:44 ` Akinobu Mita
2014-02-20 19:20 ` Nicholas A. Bellinger
2014-02-20 19:16 ` Martin K. Petersen
2014-02-20 19:28 ` Nicholas A. Bellinger
2014-02-21 23:56 ` Jens Axboe [this message]
2014-02-24 22:15 ` Muthu Kumar
2014-02-24 22:37 ` Jens Axboe
2014-02-24 23:01 ` Muthu Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140221235648.GG29129@kernel.dk \
--to=axboe@kernel.dk \
--cc=akinobu.mita@gmail.com \
--cc=hch@lst.de \
--cc=kmo@daterainc.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox