From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: loading scsi_debug with data integrity hits BUG_ON Date: Fri, 21 Feb 2014 15:56:48 -0800 Message-ID: <20140221235648.GG29129@kernel.dk> References: <1392858619.22195.24.camel@haakon3.risingtidesystems.com> <1392924492.29525.22.camel@haakon3.risingtidesystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f50.google.com ([209.85.160.50]:42823 "EHLO mail-pb0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753468AbaBUX4w (ORCPT ); Fri, 21 Feb 2014 18:56:52 -0500 Received: by mail-pb0-f50.google.com with SMTP id rq2so4112503pbb.37 for ; Fri, 21 Feb 2014 15:56:52 -0800 (PST) Content-Disposition: inline In-Reply-To: <1392924492.29525.22.camel@haakon3.risingtidesystems.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Nicholas A. Bellinger" Cc: "Martin K. Petersen" , Akinobu Mita , "linux-scsi@vger.kernel.org" , Christoph Hellwig , Sagi Grimberg , kmo@daterainc.com On Thu, Feb 20 2014, Nicholas A. Bellinger wrote: > On Thu, 2014-02-20 at 14:16 -0500, Martin K. Petersen wrote: > > >>>>> "nab" == Nicholas A Bellinger writes: > > > > nab> Given that there is no (easy) way to ascertain what the original > > nab> value of bio_integrity->bip_iter.bi_size was post > > nab> bio_integrity_advance(), dropping this BUG_ON() probably makes the > > nab> most sense. > > > > nab> MKP + Jens, care to ACK + pickup..? > > > > Please remove total as suggested by Akinobu. > > > > Acked-by: Martin K. Petersen > > > > Thanks. Here's an updated patch for Jen's to pickup. Got it, thanks! -- Jens Axboe