public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Jens Axboe <axboe@kernel.dk>,
	Nicholas Bellinger <nab@linux-iscsi.org>,
	linux-scsi@vger.kernel.org
Subject: Re: Proposal for a scalable SCSI midlayer
Date: Sun, 23 Feb 2014 20:25:49 -0800	[thread overview]
Message-ID: <20140224042549.GA11583@infradead.org> (raw)
In-Reply-To: <1393186218.9743.3.camel@dabdike>

On Sun, Feb 23, 2014 at 02:10:18PM -0600, James Bottomley wrote:
> If we can do this, that would be great, because it cuts down on the
> maintenance burden for all of us and gives some benefits at least to
> non-MQ hardware.

So far this seems to work out great, and I think we will be able to
stick to it.

> > Even when avoiding the host lock by replacing it with atomic counters we'd
> > run into multiple host or target-wide shared cache lines for each I/O
> > submission or completion.
> 
> Right ... my ideal here if we can achieve it would be lockless threaded
> models, where we could make guarantees like single thread of execution
> per command, so all command state could be lockless.  Even CPU dedicated
> to single device would give us all device state lockless and the
> necessary cache hotness (although this may not be feasible).

It's not fitting the current blk-mq model, which I'd much prefer to
follow for now.  As Jens pointed out in the previous discussion blk-mq
tries to map to cpu-local queues as much as possible, but there's no
hard guarantee.

> >  - implement BIDI support in blk-mq.  This is currently missing entirely
> >    and will be needed to support the OSD2 protocol, as well as a few
> >    SBC commands through sg_io.
> 
> Ambivalent.  We need bidi support for OSD arrays and some of the more
> esoteric commands, but I'm not convinced they're necessary to the
> functioning of the stack.

It's needed so that we get a full replacement of the old code, so we'll
have to tackle it eventually.  I wish we could simply avoid it, but life
ain't that easy.


  reply	other threads:[~2014-02-24  4:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05 12:39 Proposal for a scalable SCSI midlayer Christoph Hellwig
2014-02-23 20:10 ` James Bottomley
2014-02-24  4:25   ` Christoph Hellwig [this message]
2014-02-26 10:59   ` Bart Van Assche
2014-02-26 17:12     ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140224042549.GA11583@infradead.org \
    --to=hch@infradead.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=axboe@kernel.dk \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox