Re: [PATCH 2/3] Add EVPD page 0x83 to sysfs

Christoph Hellwig
2014-03-05T19:43:05Z

On Wed, Mar 05, 2014 at 08:38:01AM +0100, Hannes Reinecke wrote:
> > Either way I think the call to query evpd 0 should be a separate
> > function, so even if we don't store the information it's abstracted out.
> >
> Hmm. That would work if we were just asking for a single page; but
> when we're checking several pages (like 0x83 and 0x80) we'd need
> either to pass in a page array or querying page 0 several times.
> Neither of which is very appealing.
>
> However, specifying additional flags for the individual pages might
> work. I'll see what I can come up with.

Passing in a bitmask or flags seems useful. Even better storing it in the
scsi_device. Note that I expect the place that need to know the EVPD
patch to grow slowly but steadily over time.