Re: [PATCH 2/3] Add EVPD page 0x83 to sysfs

Hannes Reinecke
2014-03-07T10:35:36Z

On 03/07/2014 11:11 AM, Christoph Hellwig wrote:
> On Thu, Mar 06, 2014 at 10:01:05AM +0100, Hannes Reinecke wrote:
>> I am somewhat reluctant here.
>>
>> Adding separate flags like 'support_vpd_pg83' is a bit pointless,
>> given that we might as well check for vpg_pg83.
>>
>> So the only 'proper' solution would be to add a bitmap of supported
>> pages; however, this would be 256 bits = 32 bytes of additional
>> space required for struct sdev.
>> Which I'm a bit reluctant do to, as it'll be a sparse array in most
>> cases, adding to quite some wasted space.
>
> Might want to keep it a local bitmap for now, but I suspect we'll
> want it exposed sooner or later.
>
Agree. But for now I'd like to keep it as it is (ie without bitmap);
there is no real benefit for just the two pages we're exposing right
now.

Or, to be precise, we _might_ be exporting if those patches ever go
upstream :-(

Having any indication here would be good.
Can't we have a patch handling session at LSF?
It really is no fun, having tons of patches and no idea whether they
ever make it upstream.

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html