Re: [PATCH 2/3] Add EVPD page 0x83 to sysfs

Christoph Hellwig
2014-03-07T10:11:27Z

On Thu, Mar 06, 2014 at 10:01:05AM +0100, Hannes Reinecke wrote:
> I am somewhat reluctant here.
>
> Adding separate flags like 'support_vpd_pg83' is a bit pointless,
> given that we might as well check for vpg_pg83.
>
> So the only 'proper' solution would be to add a bitmap of supported
> pages; however, this would be 256 bits = 32 bytes of additional
> space required for struct sdev.
> Which I'm a bit reluctant do to, as it'll be a sparse array in most
> cases, adding to quite some wasted space.

Might want to keep it a local bitmap for now, but I suspect we'll
want it exposed sooner or later.