From: wenxiong@vmlinux.vnet.ibm.com
To: James.Bottomley@HansenPartnership.com
Cc: linux-scsi@vger.kernel.org, bjking1@us.ibm.com,
Alexander Gordeev <agordeev@redhat.com>,
Brian King <brking@linux.vnet.ibm.com>
Subject: [PATCH RESEND 4/7] ipr: Get rid of superfluous call to pci_disbale_msi/msix()
Date: Wed, 12 Mar 2014 16:08:49 -0500 [thread overview]
Message-ID: <20140312210906.288887472@vmlinux.vnet.ibm.com> (raw)
In-Reply-To: 20140312210845.384489953@vmlinux.vnet.ibm.com
[-- Attachment #1: 001_msix --]
[-- Type: text/plain, Size: 936 bytes --]
From: Alexander Gordeev <agordeev@redhat.com>
There is no need to call pci_disable_msi() or pci_disable_msix()
in case the call to pci_enable_msi() or pci_enable_msix() failed.
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Acked-by: Brian King <brking@linux.vnet.ibm.com>
---
drivers/scsi/ipr.c | 2 --
1 file changed, 2 deletions(-)
Index: b/drivers/scsi/ipr.c
===================================================================
--- a/drivers/scsi/ipr.c 2014-03-11 17:16:08.849955755 -0500
+++ b/drivers/scsi/ipr.c 2014-03-11 17:18:06.709957199 -0500
@@ -9329,7 +9329,6 @@ static int ipr_enable_msix(struct ipr_io
if (err < 0) {
ipr_wait_for_pci_err_recovery(ioa_cfg);
- pci_disable_msix(ioa_cfg->pdev);
return err;
}
@@ -9353,7 +9352,6 @@ static int ipr_enable_msi(struct ipr_ioa
if (err < 0) {
ipr_wait_for_pci_err_recovery(ioa_cfg);
- pci_disable_msi(ioa_cfg->pdev);
return err;
}
--
next prev parent reply other threads:[~2014-03-12 21:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 21:08 [PATCH RESEND 0/7] New CCINs and several patches for new improvement wenxiong
2014-03-12 21:08 ` [PATCH RESEND 1/7] ipr: Remove extended delay bit on GSCSI reads/writes ops wenxiong
2014-03-14 15:50 ` Brian King
2014-03-12 21:08 ` [PATCH RESEND 2/7] ipr: Add new CCIN definition for new hardware support wenxiong
2014-03-12 21:08 ` [PATCH RESEND 3/7] ipr: Handle early EEH wenxiong
2014-03-12 21:08 ` wenxiong [this message]
2014-03-19 19:55 ` [PATCH RESEND 4/7] ipr: Get rid of superfluous call to pci_disbale_msi/msix() James Bottomley
2014-03-19 20:26 ` Brian King
2014-03-19 20:57 ` James Bottomley
2014-03-12 21:08 ` [PATCH RESEND 5/7] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() wenxiong
2014-03-12 21:08 ` [PATCH RESEND 6/7] ipr: Format HCAM overlay ID 0x21 wenxiong
2014-03-12 21:08 ` [PATCH RESEND 7/7] ipr: Add new CCIN definition for Grand Canyon support wenxiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312210906.288887472@vmlinux.vnet.ibm.com \
--to=wenxiong@vmlinux.vnet.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agordeev@redhat.com \
--cc=bjking1@us.ibm.com \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).