From: Tejun Heo <tj@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
James Bottomley <jbottomley@parallels.com>,
linux-ide@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
Jim Davis <jim.epost@gmail.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH -next] libata.h: add stub for ata_sas_port_resume
Date: Wed, 19 Mar 2014 13:58:52 -0400 [thread overview]
Message-ID: <20140319175852.GD19874@htj.dyndns.org> (raw)
In-Reply-To: <5329D7F1.4030400@infradead.org>
On Wed, Mar 19, 2014 at 10:46:25AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build error when CONFIG_PM is not enabled by adding a stub
> function in <linux/libata.h>.
>
> drivers/scsi/libsas/sas_ata.c: In function 'sas_resume_sata':
> drivers/scsi/libsas/sas_ata.c:756:3: error: implicit declaration of function 'ata_sas_port_resume' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> ---
> include/linux/libata.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- linux-next-20140319.orig/include/linux/libata.h
> +++ linux-next-20140319/include/linux/libata.h
> @@ -1148,6 +1148,9 @@ static inline void ata_sas_port_suspend(
> static inline void ata_sas_port_async_resume(struct ata_port *ap)
> {
> }
> +static inline void ata_sas_port_resume(struct ata_port *ap)
> +{
> +}
> #endif
> extern int ata_ratelimit(void);
> extern void ata_msleep(struct ata_port *ap, unsigned int msecs);
Applied to libata/for-3.15.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-03-19 17:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 17:46 [PATCH -next] libata.h: add stub for ata_sas_port_resume Randy Dunlap
2014-03-19 17:58 ` Tejun Heo [this message]
2014-03-19 18:14 ` Dan Williams
2014-03-19 20:32 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319175852.GD19874@htj.dyndns.org \
--to=tj@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=jbottomley@parallels.com \
--cc=jim.epost@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox